linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: punit.agrawal@arm.com (Punit Agrawal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/11] arm64: hugetlb: set_huge_pte_at Add WARN_ON on !pte_present
Date: Mon, 22 May 2017 15:39:48 +0100	[thread overview]
Message-ID: <20170522143958.12867-3-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170522143958.12867-1-punit.agrawal@arm.com>

From: Steve Capper <steve.capper@arm.com>

This patch adds a WARN_ON to set_huge_pte_at as the accessor assumes
that entries to be written down are all present. (There are separate
accessors to clear huge ptes).

We will need to handle the !pte_present case where memory offlining
is used on hugetlb pages. swap and migration entries will be supplied
to set_huge_pte_at in this case.

Cc: David Woods <dwoods@mellanox.com>
Signed-off-by: Steve Capper <steve.capper@arm.com>
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 arch/arm64/mm/hugetlbpage.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index 425a8fcd3d38..0389e2ed51f1 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -69,6 +69,12 @@ void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
 	unsigned long pfn;
 	pgprot_t hugeprot;
 
+	/*
+	 * Code needs to be expanded to handle huge swap and migration
+	 * entries. Needed for HUGETLB and MEMORY_FAILURE.
+	 */
+	WARN_ON(!pte_present(pte));
+
 	if (ncontig == 1) {
 		set_pte_at(mm, addr, ptep, pte);
 		return;
-- 
2.11.0

  parent reply	other threads:[~2017-05-22 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 14:39 [PATCH v3 00/11] arm64: Enable contiguous pte hugepage support Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal [this message]
2017-05-22 14:39 ` [PATCH v3 02/11] arm64: hugetlb: Refactor find_num_contig Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 03/11] arm64: hugetlb: Introduce pte_pgprot helper Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 04/11] arm64: hugetlb: Remove spurious calls to huge_ptep_offset Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 05/11] arm64: hugetlb: Spring clean huge pte accessors Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 06/11] arm64: hugetlb: Add break-before-make logic for contiguous entries Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 07/11] arm64: hugetlbpages: Handle swap entries in huge_pte_offset() for contiguous hugepages Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 08/11] arm64: hugetlb: Override huge_pte_clear() to support " Punit Agrawal
2017-05-22 16:45   ` [PATCH v3.1 8/11] " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 09/11] arm64: hugetlb: Override set_huge_swap_pte_at() " Punit Agrawal
2017-05-22 16:48   ` [PATCH v3.1 9/11] " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 10/11] arm64: Re-enable support for " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 11/11] arm64: hugetlb: Cleanup setup_hugepagesz Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522143958.12867-3-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).