From: punit.agrawal@arm.com (Punit Agrawal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/11] arm64: hugetlbpages: Handle swap entries in huge_pte_offset() for contiguous hugepages
Date: Mon, 22 May 2017 15:39:54 +0100 [thread overview]
Message-ID: <20170522143958.12867-9-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170522143958.12867-1-punit.agrawal@arm.com>
huge_pte_offset() was updated to correctly handle swap entries for
hugepages. With the addition of the size parameter, it is now possible
to disambiguate whether the request is for a regular hugepage or a
contiguous hugepage.
Fix huge_pte_offset() for contiguous hugepages by using the size to find
the correct page table entry.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: David Woods <dwoods@mellanox.com>
---
arch/arm64/mm/hugetlbpage.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index f2c976464f39..e9061704aec3 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -195,6 +195,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
+ pte_t *pte;
pgd = pgd_offset(mm, addr);
pr_debug("%s: addr:0x%lx pgd:%p\n", __func__, addr, pgd);
@@ -202,19 +203,29 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
return NULL;
pud = pud_offset(pgd, addr);
- if (pud_none(*pud))
+ if (pud_none(*pud) && sz != PUD_SIZE)
return NULL;
/* swap or huge page */
if (!pud_present(*pud) || pud_huge(*pud))
return (pte_t *)pud;
/* table; check the next level */
+ if (sz == CONT_PMD_SIZE)
+ addr &= CONT_PMD_MASK;
+
pmd = pmd_offset(pud, addr);
- if (pmd_none(*pmd))
+ if (pmd_none(*pmd) &&
+ !(sz == PMD_SIZE || sz == CONT_PMD_SIZE))
return NULL;
if (!pmd_present(*pmd) || pmd_huge(*pmd))
return (pte_t *)pmd;
+ if (sz == CONT_PTE_SIZE) {
+ pte = pte_offset_kernel(
+ pmd, (addr & CONT_PTE_MASK));
+ return pte;
+ }
+
return NULL;
}
--
2.11.0
next prev parent reply other threads:[~2017-05-22 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:39 [PATCH v3 00/11] arm64: Enable contiguous pte hugepage support Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 01/11] arm64: hugetlb: set_huge_pte_at Add WARN_ON on !pte_present Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 02/11] arm64: hugetlb: Refactor find_num_contig Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 03/11] arm64: hugetlb: Introduce pte_pgprot helper Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 04/11] arm64: hugetlb: Remove spurious calls to huge_ptep_offset Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 05/11] arm64: hugetlb: Spring clean huge pte accessors Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 06/11] arm64: hugetlb: Add break-before-make logic for contiguous entries Punit Agrawal
2017-05-22 14:39 ` Punit Agrawal [this message]
2017-05-22 14:39 ` [PATCH v3 08/11] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages Punit Agrawal
2017-05-22 16:45 ` [PATCH v3.1 8/11] " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 09/11] arm64: hugetlb: Override set_huge_swap_pte_at() " Punit Agrawal
2017-05-22 16:48 ` [PATCH v3.1 9/11] " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 10/11] arm64: Re-enable support for " Punit Agrawal
2017-05-22 14:39 ` [PATCH v3 11/11] arm64: hugetlb: Cleanup setup_hugepagesz Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522143958.12867-9-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).