Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: geomatsi@gmail.com (Sergey Matyukevich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR
Date: Mon, 22 May 2017 23:30:12 +0300	[thread overview]
Message-ID: <20170522203012.k2f2kizp5jkiliq7@speedy.hunter> (raw)
In-Reply-To: <20170522092900.7v2mg5zkbt6eclhr@flea.lan>

> > For more information see:
> > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
> 
> Same remark here than on the first patch

Ok, I will provide a more detailed commit message
w/o external references.

> > +&spi0 {
> > +	status = "okay";
> > +
> > +	flash at 0 {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > +		reg = <0>;
> > +		spi-max-frequency = <40000000>;
> 
> How do the other OPi Zero that doesn't have that SPI flash behave?
Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash
was optional in the first production batch in Dec 2016. In later
batches flash chip was pre-populated. However there are should
be quite a few boards around which do not have flash.

Does it make sense to set status to 'disabled' by default adding
appropriate comment in the commit message ?

> > +
> > +		partition at 00000000 {
> > +			reg = <0x00000000 0x200000>;	/* 2Mb */
> > +		};
> 
> There's no need to create a first partition, this needs to be
> user-defined.

Ok, than it probably makes sense to drop it from dts. User-defined
list of partitions can be passed via kernel command line.

Thanks,
Sergey

  reply	other threads:[~2017-05-22 20:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 21:35 [PATCH 0/2] orange-pi-zero: minor updates for board peripherals Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip Sergey Matyukevich
2017-05-22  7:49   ` Maxime Ripard
2017-05-22 19:49     ` Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR Sergey Matyukevich
2017-05-22  9:29   ` Maxime Ripard
2017-05-22 20:30     ` Sergey Matyukevich [this message]
2017-05-24  6:35       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522203012.k2f2kizp5jkiliq7@speedy.hunter \
    --to=geomatsi@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox