linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/4] arm64: kgdb: fix single stepping
Date: Tue, 23 May 2017 13:30:54 +0900	[thread overview]
Message-ID: <20170523043058.5463-1-takahiro.akashi@linaro.org> (raw)

This is the third version of my kgdb patch for fixing single stepping.
(Sorry for this lazy update.)


Kgdb support on arm64 was merged in v3.15, but from its first appearance,
"single step" has never worked well. This patchset fixes all the error
cases I found so far. Issues are reproducable, at least, on Hikey and fast
model and I tested the patches on both of them.

The original patch[1] was splitted into three pieces, patch #1 to #3,
addressing issues one by one, in order for necessary part of changes to
be applied to specific version of kernels, but it might no longer make
much sense.

Regarding to patch #4, I'm not still sure whether it is a right fix,
but it certainly fixes some corner case.

Changes for v3: (May 23, 2017)
* simplify patch #1 to respect the original code
* swap patch #2 and #3
* add patch #4

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/295632.html

AKASHI Takahiro (4):
  arm64: kgdb: fix single stepping
  arm64: kgdb: disable interrupts while a software step is enabled
  arm64: kgdb: prevent kgdb from being invoked recursively
  kgdb: select a correct cpu while in a single stepping

 arch/arm64/kernel/kgdb.c  | 62 ++++++++++++++++++++++++++++++++++++++---------
 kernel/debug/debug_core.c |  8 +++---
 2 files changed, 55 insertions(+), 15 deletions(-)

-- 
2.11.1

             reply	other threads:[~2017-05-23  4:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23  4:30 AKASHI Takahiro [this message]
2017-05-23  4:30 ` [PATCH v3 1/4] arm64: kgdb: fix single stepping AKASHI Takahiro
2017-06-05 16:29   ` Will Deacon
2017-06-07  4:43     ` AKASHI Takahiro
2017-05-23  4:30 ` [PATCH v3 2/4] arm64: kgdb: disable interrupts while a software step is enabled AKASHI Takahiro
2017-06-05 16:29   ` Will Deacon
2017-06-07  5:34     ` AKASHI Takahiro
2017-06-07 16:50       ` Will Deacon
2017-06-20  2:43         ` AKASHI Takahiro
2017-06-20 17:07           ` Will Deacon
2017-06-21  2:43             ` AKASHI Takahiro
2017-06-21 10:00               ` Will Deacon
2017-05-23  4:30 ` [PATCH v3 3/4] arm64: kgdb: prevent kgdb from being invoked recursively AKASHI Takahiro
2017-05-23  4:30 ` [PATCH v3 4/4] kgdb: select a correct cpu while in a single stepping AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523043058.5463-1-takahiro.akashi@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).