From: riel@redhat.com (riel at redhat.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] fork, random: use get_random_canary to set tsk->stack_canary
Date: Wed, 24 May 2017 11:57:48 -0400 [thread overview]
Message-ID: <20170524155751.424-3-riel@redhat.com> (raw)
In-Reply-To: <20170524155751.424-1-riel@redhat.com>
From: Rik van Riel <riel@redhat.com>
Use the ascii-armor canary to prevent unterminated C string overflows
from being able to successfully overwrite the canary, even if they
somehow obtain the canary value.
Inspired by execshield ascii-armor and Daniel Micay's linux-hardened tree.
Signed-off-by: Rik van Riel <riel@redhat.com>
---
kernel/fork.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index aa1076c5e4a9..b3591e9250a8 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -560,7 +560,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node)
set_task_stack_end_magic(tsk);
#ifdef CONFIG_CC_STACKPROTECTOR
- tsk->stack_canary = get_random_long();
+ tsk->stack_canary = get_random_canary();
#endif
/*
--
2.9.3
next prev parent reply other threads:[~2017-05-24 15:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 15:57 [PATCH v2 0/5] stackprotector: ascii armor the stack canary riel at redhat.com
2017-05-24 15:57 ` [PATCH 1/5] random, stackprotect: introduce get_random_canary function riel at redhat.com
2017-05-24 16:15 ` Kees Cook
2017-05-24 15:57 ` riel at redhat.com [this message]
2017-05-24 16:16 ` [PATCH 2/5] fork, random: use get_random_canary to set tsk->stack_canary Kees Cook
2017-05-24 15:57 ` [PATCH 3/5] x86: ascii armor the x86_64 boot init stack canary riel at redhat.com
2017-05-24 16:16 ` Kees Cook
2017-05-24 15:57 ` [PATCH 4/5] arm64: ascii armor the arm64 " riel at redhat.com
2017-05-24 16:16 ` Kees Cook
2017-05-24 15:57 ` [PATCH 5/5] sh64: ascii armor the sh64 " riel at redhat.com
2017-05-24 16:34 ` Rik van Riel
2017-05-24 16:35 ` Kees Cook
2017-09-19 17:16 ` [kernel-hardening] [PATCH v2 0/5] stackprotector: ascii armor the " Solar Designer
2017-09-19 20:22 ` Kees Cook
2017-09-19 21:10 ` Daniel Micay
2017-09-20 11:18 ` Yann Droneaud
2017-09-20 15:03 ` Solar Designer
-- strict thread matches above, loose matches on Subject: below --
2017-05-19 21:26 riel at redhat.com
2017-05-19 21:26 ` [PATCH 2/5] fork, random: use get_random_canary to set tsk->stack_canary riel at redhat.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524155751.424-3-riel@redhat.com \
--to=riel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).