From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Date: Thu, 25 May 2017 15:00:09 +0800 [thread overview]
Message-ID: <20170525070007.GU26102@dragon> (raw)
In-Reply-To: <20170522131010.3537-1-nikita.yoush@cogentembedded.com>
On Mon, May 22, 2017 at 04:10:10PM +0300, Nikita Yushchenko wrote:
> ZII dev board rev B has a Holt Hi8435 connected to dspi2.
> Add it to device tree.
>
> ZII dev board rev C does not have that, so use rev-b dts file,
> not common dtsi file.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> index 37f95427616f..f433465c3a7c 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> @@ -348,6 +348,25 @@
> };
> };
>
> +&edma1 {
> + status = "okay";
> +};
> +
> +&dspi2 {
Please keep these labelled nodes sort alphabetically.
> + bus-num = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_dspi2>;
> + status = "okay";
We usually have 'status' line at the bottom of property list.
> + spi-num-chipselects = <2>;
> +
> + hi8435 at 1 {
Node name should be something generic, while label can be specific
model name. The following form might be better.
hi8435: sensor at 1
Shawn
> + compatible = "holt,hi8435";
> + reg = <1>;
> + spi-max-frequency = <20000000>;
> + gpios = <&gpio5 3 0>;
> + };
> +};
> +
> &i2c0 {
> clock-frequency = <100000>;
> pinctrl-names = "default";
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-05-25 7:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:10 [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko
2017-05-22 16:20 ` Stefan Agner
2017-05-22 16:29 ` Nikita Yushchenko
2017-05-22 18:21 ` Andrew Lunn
2017-05-23 6:02 ` Nikita Yushchenko
2017-05-25 7:19 ` Shawn Guo
2017-05-25 8:03 ` Nikita Yushchenko
2017-05-28 15:09 ` Jonathan Cameron
2017-05-25 7:00 ` Shawn Guo [this message]
2017-05-25 8:06 ` Nikita Yushchenko
2017-05-25 8:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525070007.GU26102@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox