From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL (RESEND)] ARM: uniphier: UniPhier fixes for v4.12
Date: Thu, 25 May 2017 16:59:02 -0700 [thread overview]
Message-ID: <20170525235902.GA25387@localhost> (raw)
In-Reply-To: <CAK7LNARbSkbEOhs7QMd+6VV+KWbkjK4LR9rmQ=YBWqPY+8_XPQ@mail.gmail.com>
On Mon, May 22, 2017 at 11:03:49AM +0900, Masahiro Yamada wrote:
> Hi Arnd, Olof,
>
> Last week, I thought I found a problem in my pull request,
> but it turned out my misunderstanding.
>
> So, my pull request I sent is OK.
> I am re-sending this request mail for clarification.
>
> Here are some ARM UniPhier SoC fixes for v4.12.
> Due to the eMMC driver update, PHY parameters must be specified
> via DT to make the eMMC controller work again.
That's not good, that's a regression in behavior. The driver should
have a fallback when the properties are not present to avoid regressions
like these.
Please work with the driver maintainer to either get them to revert
their change that regresses you, or promptly fix it appropriately with
fallback values.
Also, the driver changes were commited back in March, with plenty of time
to land DT changes well before the merge window. Waiting until the merge
window is closed is not appropriate -- this should have come in earlier.
-Olof
next prev parent reply other threads:[~2017-05-25 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 2:03 [GIT PULL (RESEND)] ARM: uniphier: UniPhier fixes for v4.12 Masahiro Yamada
2017-05-25 23:59 ` Olof Johansson [this message]
2017-05-26 1:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525235902.GA25387@localhost \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox