From: dongas86@gmail.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Date: Wed, 31 May 2017 14:36:20 +0800 [thread overview]
Message-ID: <20170531063620.GB16812@b29396-OptiPlex-7040> (raw)
In-Reply-To: <20170525205455.GB9501@mai>
Hi Daniel,
On Thu, May 25, 2017 at 10:54:55PM +0200, Daniel Lezcano wrote:
> On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
> > IMX Timer/PWM Module (TPM) supports both timer and pwm function while
> > this patch only adds the timer support. PWM would be added later.
> >
> > The TPM counter, compare and capture registers are clocked by an
> > asynchronous clock that can remain enabled in low power modes.
> >
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Signed-off-by: Bai Ping <ping.bai@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
>
> [ ... ]
>
> > + val = __raw_readl(timer_base + TPM_C0SC);
> > + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> > + __raw_writel(val, timer_base + TPM_C0SC);
>
> Hi Dong,
>
> why are you using __raw_write/__raw_read instead of regular readl/writel?
>
Sorry for missing the second throught of it.
Will change to readl/writel as Arnd pointed out in another mail.
Regards
Dong Aisheng
next prev parent reply other threads:[~2017-05-31 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 7:29 [PATCH 1/2] dt-bindings: timer: add nxp tpm timer binding doc Dong Aisheng
2017-05-13 7:29 ` [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Dong Aisheng
2017-05-25 20:54 ` Daniel Lezcano
2017-05-31 6:36 ` Dong Aisheng [this message]
2017-05-25 21:02 ` Arnd Bergmann
2017-05-31 6:34 ` Dong Aisheng
2017-05-19 1:25 ` [PATCH 1/2] dt-bindings: timer: add nxp tpm timer binding doc Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531063620.GB16812@b29396-OptiPlex-7040 \
--to=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox