From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/7] arm: fix return value of parse_cpu_capacity
Date: Wed, 31 May 2017 19:40:02 +0100 [thread overview]
Message-ID: <20170531184002.GC27796@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170531165931.6945-3-juri.lelli@arm.com>
On Wed, May 31, 2017 at 05:59:26PM +0100, Juri Lelli wrote:
> parse_cpu_capacity() has to return 0 on failure, but it currently returns
> 1 instead if raw_capacity kcalloc failed.
>
> Fix it (by directly returning 0).
>
> Cc: Russell King <linux@arm.linux.org.uk>
You can drop these Cc's now. Thanks.
> Reported-by: Morten Rasmussen <morten.rasmussen@arm.com>
> Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT')
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> Acked-by: Vincent Guittot <vincent.guittot@linaor.org>
> ---
> arch/arm/kernel/topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index f8a3ab82e77f..1b8ec3054642 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu)
> if (!raw_capacity) {
> pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
> cap_parsing_failed = true;
> - return !ret;
> + return 0;
> }
> }
> capacity_scale = max(cpu_capacity, capacity_scale);
> --
> 2.11.0
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-05-31 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 16:59 [PATCH v5 0/7] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-05-31 16:59 ` [PATCH v5 1/7] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-05-31 16:59 ` [PATCH v5 2/7] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-05-31 18:40 ` Russell King - ARM Linux [this message]
2017-05-31 16:59 ` [PATCH v5 3/7] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-05-31 16:59 ` [PATCH v5 4/7] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-05-31 16:59 ` [PATCH v5 5/7] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-05-31 16:59 ` [PATCH v5 6/7] arm,arm64,drivers: move externs in a new header file Juri Lelli
2017-05-31 16:59 ` [PATCH v5 7/7] arm, arm64, drivers: add a prefix to drivers arch_topology interfaces Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531184002.GC27796@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).