From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: Fix Ethernet PHY reset polarity
Date: Sun, 4 Jun 2017 20:49:37 +0200 [thread overview]
Message-ID: <20170604184937.GA10273@lunn.ch> (raw)
In-Reply-To: <1496597475-1361-1-git-send-email-festevam@gmail.com>
On Sun, Jun 04, 2017 at 02:31:15PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The FEC driver ignores the GPIO polarity from 'phy-reset-gpios' and
> considers that the Ethernet PHY is active low, unless the
> property 'phy-reset-active-high' is present.
>
> Fix the device tree description by explicitly passing the
> 'GPIO_ACTIVE_LOW' flag to the 'phy-reset-gpios' property.
Hi Fabio
Device tree bindings are supposed to be stable. So we can never fix
the FEC to respect the flag. This change to 'GPIO_ACTIVE_LOW' makes
the suggestion the flag is used, and can be set to GPIO_ACTIVE_HIGH.
If i were to change the value, i would set it to 42, or something new
like GPIO_FLAGS_BROKEN.
Andrew
next prev parent reply other threads:[~2017-06-04 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:31 [PATCH] ARM: dts: imx: Fix Ethernet PHY reset polarity Fabio Estevam
2017-06-04 18:49 ` Andrew Lunn [this message]
2017-06-04 21:06 ` Fabio Estevam
2017-06-05 14:21 ` Andrew Lunn
2017-06-05 14:19 ` Andrew Lunn
2017-06-05 15:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604184937.GA10273@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).