From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: marvell: 8040-mcbin: Enable 1GB Ethernet
Date: Tue, 6 Jun 2017 14:34:46 +0100 [thread overview]
Message-ID: <20170606133446.GI4902@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170605200107.7692-1-marc.zyngier@arm.com>
On Mon, Jun 05, 2017 at 09:01:07PM +0100, Marc Zyngier wrote:
> Enable the 1GB Ethernet interface that lives on the slave CP110,
> with its corresponding phy (that oddly lives on the master CP110).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index f7bb0cc03147..1eb3cd5332c1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -100,6 +100,12 @@
> status = "okay";
> };
>
> +&cpm_mdio {
> + phy0: ethernet-phy at 0 {
As the board has multiple phys, can we use a more descriptive label
here, such as "ge_phy" (for gigabit ethernet phy) to distinugish it
from the 10G PHYs?
> +&cps_ethernet {
> + status = "okay";
> +};
> +
> +&cps_eth1 {
Labelling up the connector as is done elsewhere in the file would be
nice:
/* CPS Lane 0 - J5 (Gigabit RJ45) */
> + status = "okay";
> + phy = <&phy0>;
> + phy-mode = "sgmii";
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-06-06 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:01 [PATCH] arm64: dts: marvell: 8040-mcbin: Enable 1GB Ethernet Marc Zyngier
2017-06-05 21:16 ` Andrew Lunn
2017-06-06 8:21 ` Marc Zyngier
2017-06-06 12:10 ` Andrew Lunn
2017-06-06 9:02 ` Thomas Petazzoni
2017-06-06 9:06 ` Thomas Petazzoni
2017-06-06 9:18 ` Marc Zyngier
2017-06-06 9:36 ` Thomas Petazzoni
2017-06-06 9:57 ` Russell King - ARM Linux
2017-06-06 9:16 ` Marc Zyngier
2017-06-06 9:19 ` Thomas Petazzoni
2017-06-06 12:52 ` Thomas Petazzoni
2017-06-06 13:34 ` Russell King - ARM Linux [this message]
2017-06-06 13:48 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606133446.GI4902@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).