From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Wed, 7 Jun 2017 11:26:12 +0800 Subject: [PATCH] arm64: dts: ls1088a: update sata node In-Reply-To: References: <1496648752-27627-1-git-send-email-andy.tang@nxp.com> <20170605151441.GL4094@dragon> Message-ID: <20170607032611.GB31070@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 07, 2017 at 02:38:36AM +0000, Andy Tang wrote: > Hi Shawn, > > Please see the explanation below. > > -----Original Message----- > From: Shawn Guo [mailto:shawnguo at kernel.org] > Sent: Monday, June 05, 2017 11:15 PM > To: Andy Tang > Cc: mark.rutland at arm.com; catalin.marinas at arm.com; will.deacon at arm.com; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org > Subject: Re: [PATCH] arm64: dts: ls1088a: update sata node > > On Mon, Jun 05, 2017 at 03:45:52PM +0800, Yuantian Tang wrote: > > 1. Remove ls1043a compatible string from node > > Can you explain a bit why the compatible string needs to be dropped? > > A: We thought ls1088 and ls1043 are 100% compatible in regard to sata. > But actually, they are not because their ecc register address is different. It's quite common that the same IP block is integrated into different SoCs with different register address. That shouldn't be the reason for a new compatible. Shawn