From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] net: mvmdio: move the read valid check into its own function
Date: Wed, 7 Jun 2017 16:43:08 +0200 [thread overview]
Message-ID: <20170607144308.GB4173@kwain> (raw)
In-Reply-To: <71f0a99b-4736-a405-1d06-9c05f80aa327@cogentembedded.com>
Hello,
On Wed, Jun 07, 2017 at 01:00:21PM +0300, Sergei Shtylyov wrote:
> On 6/7/2017 11:38 AM, Antoine Tenart wrote:
> >
> > - val = readl(dev->regs);
> > - if (!(val & MVMDIO_SMI_READ_VALID)) {
> > + if (orion_mdio_smi_is_read_valid(dev)) {
> > dev_err(bus->parent, "SMI bus read not valid\n");
>
> I think you reversed the valuid/invalid sense in the new function's name.
Good catch, I'll fix this.
Thanks!
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170607/61219f52/attachment.sig>
next prev parent reply other threads:[~2017-06-07 14:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 8:38 [PATCH 0/9] net: mvmdio: add xSMI support Antoine Tenart
2017-06-07 8:38 ` [PATCH 1/9] net: mvmdio: reorder headers alphabetically Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 2/9] net: mvmdio: use tabs for defines Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 3/9] net: mvmdio: use GENMASK for masks Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 4/9] net: mvmdio: move the read valid check into its own function Antoine Tenart
2017-06-07 10:00 ` Sergei Shtylyov
2017-06-07 14:43 ` Antoine Tenart [this message]
2017-06-07 8:38 ` [PATCH 5/9] net: mvmdio: introduce an ops structure Antoine Tenart
2017-06-07 19:28 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 6/9] net: mvmdio: put the poll intervals in the private structure Antoine Tenart
2017-06-07 19:25 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 7/9] net: mvmdio: add xmdio support Antoine Tenart
2017-06-07 12:12 ` Andrew Lunn
2017-06-07 14:42 ` Antoine Tenart
2017-06-07 15:48 ` Florian Fainelli
2017-06-07 15:56 ` Russell King - ARM Linux
2017-06-07 16:13 ` Antoine Tenart
2017-06-07 8:38 ` [PATCH 8/9] dt-bindings: orion-mdio: document the new xmdio compatible Antoine Tenart
2017-06-07 8:38 ` [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k Antoine Tenart
2017-06-07 8:43 ` Gregory CLEMENT
2017-06-07 19:09 ` David Miller
2017-06-08 8:45 ` Antoine Tenart
2017-06-08 8:51 ` Antoine Tenart
2017-06-08 8:55 ` Gregory CLEMENT
2017-06-08 9:03 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607144308.GB4173@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox