linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PULL v2 5/6] arm64: KVM: Allow unaligned accesses at EL2
Date: Wed,  7 Jun 2017 19:11:51 +0200	[thread overview]
Message-ID: <20170607171152.21874-6-cdall@linaro.org> (raw)
In-Reply-To: <20170607171152.21874-1-cdall@linaro.org>

From: Marc Zyngier <marc.zyngier@arm.com>

We currently have the SCTLR_EL2.A bit set, trapping unaligned accesses
at EL2, but we're not really prepared to deal with it. So far, this
has been unnoticed, until GCC 7 started emitting those (in particular
64bit writes on a 32bit boundary).

Since the rest of the kernel is pretty happy about that, let's follow
its example and set SCTLR_EL2.A to zero. Modern CPUs don't really
care.

Cc: stable at vger.kernel.org
Reported-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <cdall@linaro.org>
---
 arch/arm64/kvm/hyp-init.S | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kvm/hyp-init.S b/arch/arm64/kvm/hyp-init.S
index 4072d40..3f96155 100644
--- a/arch/arm64/kvm/hyp-init.S
+++ b/arch/arm64/kvm/hyp-init.S
@@ -108,9 +108,10 @@ __do_hyp_init:
 
 	/*
 	 * Preserve all the RES1 bits while setting the default flags,
-	 * as well as the EE bit on BE.
+	 * as well as the EE bit on BE. Drop the A flag since the compiler
+	 * is allowed to generate unaligned accesses.
 	 */
-	ldr	x4, =(SCTLR_EL2_RES1 | SCTLR_ELx_FLAGS)
+	ldr	x4, =(SCTLR_EL2_RES1 | (SCTLR_ELx_FLAGS & ~SCTLR_ELx_A))
 CPU_BE(	orr	x4, x4, #SCTLR_ELx_EE)
 	msr	sctlr_el2, x4
 	isb
-- 
2.9.0

  parent reply	other threads:[~2017-06-07 17:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 17:11 [PULL v2 0/6] KVM/ARM Fixes for v4.12-rc5 - Take 2 Christoffer Dall
2017-06-07 17:11 ` [PULL v2 1/6] KVM: arm/arm64: Fix isues with GICv2 on GICv3 migration Christoffer Dall
2017-06-07 17:11 ` [PULL v2 2/6] KVM: arm/arm64: vgic-v3: Fix nr_pre_bits bitfield extraction Christoffer Dall
2017-06-07 17:11 ` [PULL v2 3/6] KVM: arm/arm64: Handle possible NULL stage2 pud when ageing pages Christoffer Dall
2017-06-07 17:11 ` [PULL v2 4/6] arm64: KVM: Preserve RES1 bits in SCTLR_EL2 Christoffer Dall
2017-06-07 17:11 ` Christoffer Dall [this message]
2017-06-07 17:11 ` [PULL v2 6/6] arm: KVM: Allow unaligned accesses at HYP Christoffer Dall
2017-06-08 13:04 ` [PULL v2 0/6] KVM/ARM Fixes for v4.12-rc5 - Take 2 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607171152.21874-6-cdall@linaro.org \
    --to=cdall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).