linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jlu@pengutronix.de (Jan Luebbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/7] EDAC drivers for Armada XP L2 and DDR
Date: Fri,  9 Jun 2017 10:31:16 +0200	[thread overview]
Message-ID: <20170609083123.6539-1-jlu@pengutronix.de> (raw)

This series add drivers for the L2 cache and DDR RAM ECC functionality as found
on the MV78230/MV78x60 SoCs. I've tested these changes with the MV78460 (on a
custom board with a DDR3 ECC DIMM).

Also contained in this series are devm_ helpers for edac_mc_/edac_device_
allocation and registration, which make error handing and cleanup simpler. They
may already be mergeable.

It seems Chris and I had a race condition, he posted a driver for this
functionality just yesterday. Compared to his submission, the L2 and DDR
support is split into two drivers for this series, as they don't actually share
any functionality.

Some further differences in this series are:
- The error details are decoded and passed to the edac error handler.
- Multiple errors are counted even if the details are unavailable.
- The DDR RAM configuration is read back to fill out the DIMM structures.
- The DDR RAM error address is calculated from the bank/row/col information.
- The L2 injection registers are exposed via debugfs instead of sysfs
  (resulting in less driver code).

Chris, how do you want to proceed? We should probably combine our efforts in one
series. I've already picked up part of DDR RAM config reading from your series
for this submission. I'll send some questions/comments to your series, as well.

Jan Luebbe (7):
  ARM: l2c: move cache-aurora-l2.h to asm/hardware
  ARM: aurora-l2: add prefix to MAX_RANGE_SIZE
  EDAC: Add missing debugfs_create_x32 wrapper
  EDAC: Add devres helpers for
    edac_mc_alloc/edac_mc_add_mc(_with_groups)
  EDAC: Add devres helpers for
    edac_device_alloc_ctl_info/edac_device_add_device
  EDAC: Add driver for the AURORA L2 cache
  EDAC: Add driver for the Marvell Armada XP SDRAM controller

 arch/arm/include/asm/hardware/cache-aurora-l2.h | 104 +++++++
 arch/arm/mm/cache-aurora-l2.h                   |  55 ----
 arch/arm/mm/cache-l2x0.c                        |   6 +-
 drivers/edac/Kconfig                            |  14 +
 drivers/edac/Makefile                           |   2 +
 drivers/edac/armada_xp_mc_edac.c                | 366 ++++++++++++++++++++++++
 drivers/edac/aurora_l2_edac.c                   | 252 ++++++++++++++++
 drivers/edac/debugfs.c                          |  11 +
 drivers/edac/edac_device.c                      |  59 ++++
 drivers/edac/edac_device.h                      |  29 ++
 drivers/edac/edac_mc.c                          |  53 ++++
 drivers/edac/edac_mc.h                          |  26 ++
 drivers/edac/edac_module.h                      |   5 +
 13 files changed, 924 insertions(+), 58 deletions(-)
 create mode 100644 arch/arm/include/asm/hardware/cache-aurora-l2.h
 delete mode 100644 arch/arm/mm/cache-aurora-l2.h
 create mode 100644 drivers/edac/armada_xp_mc_edac.c
 create mode 100644 drivers/edac/aurora_l2_edac.c

-- 
2.11.0

             reply	other threads:[~2017-06-09  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  8:31 Jan Luebbe [this message]
2017-06-09  8:31 ` [RFC PATCH 1/7] ARM: l2c: move cache-aurora-l2.h to asm/hardware Jan Luebbe
2017-06-09  8:31 ` [RFC PATCH 2/7] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Jan Luebbe
2017-06-09  8:31 ` [RFC PATCH 3/7] EDAC: Add missing debugfs_create_x32 wrapper Jan Luebbe
2017-06-09  8:31 ` [RFC PATCH 4/7] EDAC: Add devres helpers for edac_mc_alloc/edac_mc_add_mc(_with_groups) Jan Luebbe
2017-06-09  8:31 ` [RFC PATCH 5/7] EDAC: Add devres helpers for edac_device_alloc_ctl_info/edac_device_add_device Jan Luebbe
2017-06-09  8:31 ` [RFC PATCH 6/7] EDAC: Add driver for the AURORA L2 cache Jan Luebbe
2017-06-12  1:26   ` Chris Packham
2017-06-09  8:31 ` [RFC PATCH 7/7] EDAC: Add driver for the Marvell Armada XP SDRAM controller Jan Luebbe
2017-06-11 22:21   ` Chris Packham
2017-06-12  3:07   ` Chris Packham
2017-06-09  9:36 ` [RFC PATCH 0/7] EDAC drivers for Armada XP L2 and DDR Borislav Petkov
2017-06-09 13:23   ` Jan Lübbe
2017-06-09 13:37     ` Borislav Petkov
2017-06-11 22:07 ` Chris Packham
2017-06-12  4:03   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609083123.6539-1-jlu@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).