From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: ARM64: fix phy counter access failure in guest.
Date: Fri, 9 Jun 2017 10:41:34 +0200 [thread overview]
Message-ID: <20170609084134.GC6378@cbox> (raw)
In-Reply-To: <20170609162220.1460-1-huhuajun@huawei.com>
Hi,
On Sat, Jun 10, 2017 at 12:22:20AM +0800, Hu Huajun wrote:
> When reading the cntpct_el0 in guest with VHE (Virtual Host Extension)
> enabled in host, the "Unsupported guest sys_reg access" error reported.
> The reason is cnthctl_el2.EL1PCTEN is not enabled, which is expected
> to be done in kvm_timer_init_vhe(). The problem is kvm_timer_init_vhe
> is called by cpu_init_hyp_mode, and which is called when VHE is disabled.
> This patch calls kvm_timer_init_vhe() to enable cnthctl_el2.EL1PCTEN
> in cpu_hyp_reinit().
>
> Signed-off-by: Hu Huajun <huhuajun@huawei.com>
> ---
> virt/kvm/arm/arm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 3417e18..b703741 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1137,6 +1137,7 @@ static void cpu_hyp_reinit(void)
> * event was cancelled before the CPU was reset.
> */
> __cpu_init_stage2();
> + kvm_timer_init_vhe();
> } else {
> cpu_init_hyp_mode(NULL);
> }
> --
> 2.10.1
>
Could you rework this patch to remove the incorrect call to
kvm_timer_init_vhe() from cpu_init_hyp_mode() as well?
Thanks,
-Christoffer
prev parent reply other threads:[~2017-06-09 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 16:22 [PATCH] KVM: ARM64: fix phy counter access failure in guest Hu Huajun
2017-06-09 8:41 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609084134.GC6378@cbox \
--to=cdall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).