linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ralph.sennhauser@gmail.com (Ralph Sennhauser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection
Date: Fri, 9 Jun 2017 10:03:22 +0200	[thread overview]
Message-ID: <20170609100322.765adf7f@gmail.com> (raw)
In-Reply-To: <CACRpkdbRN3pgNqUJXHimpMjSOMeZepjxACveTSVzYJWneM9hOQ@mail.gmail.com>

On Fri, 9 Jun 2017 09:37:55 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud
> <richard.genoud@gmail.com> wrote:
> 
> > The blink counter A was always selected because 0 was forced in the
> > blink select counter register.
> > The variable 'set' was obviously there to be used as the register
> > value, selecting the B counter when id==1 and A counter when id==0.
> >
> > Tested on clearfog-pro (Marvell 88F6828)
> >
> > Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
> > Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> > Reviewed-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> > Signed-off-by: Richard Genoud <richard.genoud@gmail.com>  
> 
> Patch applied for fixes.
> 
> It appears this will clash with patches on the development branch :(

Hi Linus,

The commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
access") which you likely mean breaks gpio-keys, reported about an hour
ago, so you might just want to drop that one for now instead as it
needs mor work anyway.

Ralph

  parent reply	other threads:[~2017-06-09  8:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 12:18 [PATCHv2 0/2] gpio: mvebu: fixes for PWM/blink Richard Genoud
2017-06-01 12:18 ` [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Richard Genoud
2017-06-09  7:37   ` Linus Walleij
2017-06-09  7:40     ` Richard Genoud
2017-06-09  8:03     ` Ralph Sennhauser [this message]
2017-06-11 21:48       ` Linus Walleij
2017-06-12  7:17         ` Ralph Sennhauser
2017-06-01 12:18 ` [PATCHv2 2/2] gpio: mvebu: fix gpio bank registration when pwm is used Richard Genoud
2017-06-01 14:57   ` Gregory CLEMENT
2017-06-09  7:39   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609100322.765adf7f@gmail.com \
    --to=ralph.sennhauser@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).