linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES
Date: Fri, 9 Jun 2017 12:38:50 +0100	[thread overview]
Message-ID: <20170609113850.GF13955@arm.com> (raw)
In-Reply-To: <20170609102807.2992510-1-arnd@arndb.de>

Hi Arnd,

On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote:
> When CONFIG_MODULES is disabled, we cannot dereference a module pointer:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call':
> arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete type 'struct module'
>    trampoline = (unsigned long *)mod->arch.ftrace_trampoline;
> 
> Also, the within_module() function is not defined:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_nop':
> arch/arm64/kernel/ftrace.c:171:8: error: implicit declaration of function 'within_module'; did you mean 'init_module'? [-Werror=implicit-function-declaration]
> 
> This addresses both by adding the appropriate stubs.
> 
> Fixes: e71a4e1bebaf ("arm64: ftrace: add support for far branches to dynamic ftrace")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm64/include/asm/module.h | 6 ++++++
>  arch/arm64/kernel/ftrace.c      | 2 +-
>  include/linux/module.h          | 5 +++++
>  3 files changed, 12 insertions(+), 1 deletion(-)

I can't seem to reproduce this simply by disabling MODULES in defconfig.
Could you share your .config, please?

Will

  reply	other threads:[~2017-06-09 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 10:27 [PATCH] arm64: ftrace: fix building without CONFIG_MODULES Arnd Bergmann
2017-06-09 11:38 ` Will Deacon [this message]
2017-06-09 18:57   ` Arnd Bergmann
2017-06-12 12:48     ` Will Deacon
2017-06-12 13:01       ` Ard Biesheuvel
2017-06-12 14:22       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609113850.GF13955@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).