From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] arm64: mm: print out correct page table entries
Date: Fri, 9 Jun 2017 17:04:07 +0100 [thread overview]
Message-ID: <20170609160407.GK10665@leverpostej> (raw)
In-Reply-To: <1497022554-1451-1-git-send-email-kristina.martsenko@arm.com>
On Fri, Jun 09, 2017 at 04:35:52PM +0100, Kristina Martsenko wrote:
> /*
> - * Dump out the page tables associated with 'addr' in mm 'mm'.
> + * Dump out the page tables associated with 'addr' in the currently active mm.
> */
> -void show_pte(struct mm_struct *mm, unsigned long addr)
> +void show_pte(unsigned long addr)
> {
> + struct mm_struct *mm;
> pgd_t *pgd;
>
> - if (!mm)
> + if (addr < TASK_SIZE) {
> + /* TTBR0 */
> + mm = current->active_mm;
Can we log something for the active_mm == &init_mm case?
e.g.
if (addr < TASK_SIZE) {
if (current->active_mm == &init_mm)
pr_alert("[%016lx] address in unknown TTBR0 range\n",
addr);
else
mm = current->active_mm;
} ...
> + } else if (addr >= VA_START) {
> + /* TTBR1 */
> mm = &init_mm;
> + } else {
> + pr_alert("[%08lx] address between user and kernel address ranges\n",
> + addr);
I think that should be %016lx, given the address will be 64-bit.
With those:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
next prev parent reply other threads:[~2017-06-09 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 15:35 [PATCH v2 1/3] arm64: mm: print out correct page table entries Kristina Martsenko
2017-06-09 15:35 ` [PATCH v2 2/3] arm64: mm: don't print out page table entries on EL0 faults Kristina Martsenko
2017-06-09 15:50 ` Mark Rutland
2017-06-09 15:35 ` [PATCH v2 3/3] arm64: mm: print file name of faulting vma Kristina Martsenko
2017-06-09 15:54 ` Mark Rutland
2017-06-09 16:04 ` Mark Rutland [this message]
2017-06-09 16:33 ` [PATCH v2 1/3] arm64: mm: print out correct page table entries Will Deacon
2017-06-09 16:41 ` Mark Rutland
2017-06-09 20:22 ` Yury Norov
2017-06-15 10:00 ` Will Deacon
2017-06-15 10:12 ` Yury Norov
2017-06-15 10:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609160407.GK10665@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox