From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [[PATCH]] drivers: leds/trigger: system cannot enter suspend
Date: Sat, 10 Jun 2017 00:16:11 +0200 [thread overview]
Message-ID: <20170609221611.GD28596@amd> (raw)
In-Reply-To: <81f270ba-6f3c-7759-789b-181203efb7b7@ti.com>
On Wed 2017-06-07 10:38:47, Grygorii Strashko wrote:
>
>
> On 06/06/2017 11:24 PM, Bruce Zhang wrote:
> > Hi Pavel,
> >
> > It can also fix my issue by reverting the commit 5ab92a7cb. But this action only does not make led_set_brightness_nosleep function to set brightness. The heartbeat trigger timer is still running even though it is not harmful.
>
> Unfortunately, this is sort of design issue of leds triggers framework as it
> doesn't have Suspend related interfaces, so triggers continue running
> even if led, by it self, is suspended from led_classdev_suspend().
> For example, heartbeat trigger timer can be source of spurious wake-ups
> in some cases.
Yes, trigger keeps running. It should not be a problem... right?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170610/bcd6e3f4/attachment.sig>
next prev parent reply other threads:[~2017-06-09 22:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 2:36 [[PATCH]] drivers: leds/trigger: system cannot enter suspend Zhang Bo
2017-06-06 19:25 ` Pavel Machek
2017-06-06 20:05 ` Jacek Anaszewski
2017-06-06 20:19 ` Grygorii Strashko
2017-06-06 20:34 ` Pavel Machek
2017-06-06 20:38 ` Pavel Machek
2017-06-07 4:24 ` Bruce Zhang
2017-06-07 15:38 ` Grygorii Strashko
2017-06-09 22:16 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-05 7:36 Zhang Bo
2017-06-05 19:27 ` Jacek Anaszewski
2017-06-06 2:47 ` Bruce Zhang
2017-06-06 20:00 ` Jacek Anaszewski
2017-06-05 20:05 ` Pavel Machek
2017-06-06 2:11 ` Bruce Zhang
2017-06-09 11:25 ` Linus Walleij
2017-06-09 13:01 ` Bruce Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609221611.GD28596@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).