From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] arm64: fix crash when reading /proc/kcore
Date: Tue, 13 Jun 2017 16:06:20 +0200 [thread overview]
Message-ID: <20170613140620.GA10107@krava> (raw)
In-Reply-To: <CAKv+Gu_GqUPDjie0kqV32fs8ZobXe7T2KcdBmE3RuqSYaz6f1Q@mail.gmail.com>
On Tue, Jun 13, 2017 at 09:17:49AM +0200, Ard Biesheuvel wrote:
> On 13 June 2017 at 04:00, Tan Xiaojun <tanxiaojun@huawei.com> wrote:
> > On 2017/6/9 3:41, Ard Biesheuvel wrote:
> >> This is a follow-up to patches from zhonjiang [0] and myself [1] that aim
> >> to solve a problem in the kcore code, which gets confused by the presence
> >> of block mappings in the vmalloc region.
> >>
> >> While fixing the crash is quite straight forward [2], we need to tweak
> >> the kcore code itself to ensure that it operates correctly on arm64.
> >> Fortunately, we can achieve this with two very simple changes:
> >>
> >> - replace a call to is_vmalloc_or_module_addr() in read_kcore() with a
> >> comparison of the kclist type field (#1)
> >> - enable CONFIG_ARCH_PROC_KCORE_TEXT for arm64 (#2)
> >>
> >> [0] http://marc.info/?l=linux-mm&m=149632393629295&w=2
> >> [1] http://marc.info/?l=linux-mm&m=149685966530180&w=2
> >> [2] http://marc.info/?l=linux-mm&m=149694975123959&w=2
> >>
> >> Ard Biesheuvel (2):
> >> fs/proc: kcore: use kcore_list type to check for vmalloc/module
> >> address
> >> arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT
> >>
> >> arch/arm64/Kconfig | 3 +++
> >> fs/proc/kcore.c | 2 +-
> >> 2 files changed, 4 insertions(+), 1 deletion(-)
> >>
> >
> > Reported-by: Tan Xiaojun <tanxiaojun@huawei.com>
> > Tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
> >
> > Thank you for working on this problem which I reported two months ago.
> >
> > https://patchwork.kernel.org/patch/9687319/
> >
> > I tested, and it really solved the problem in Hisilicon D02/D03/D05.
> >
>
> Thank you.
>
> fs/proc/kcore.c does not have a maintainer according to
> get_maintainer.pl but it would be nice if we could get an ack on patch
> #1 from someone who is not a usual ARM suspect.
>
> Patch #1 is here:
> http://marc.info/?l=linux-kernel&m=149695092424288&w=2
>
> Ingo, Andrew, Jiri, any objections?
hi,
pretty straightforward.. looks ok to me
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
jirka
prev parent reply other threads:[~2017-06-13 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 19:41 [PATCH 0/2] arm64: fix crash when reading /proc/kcore Ard Biesheuvel
2017-06-08 19:41 ` [PATCH 1/2] fs/proc: kcore: use kcore_list type to check for vmalloc/module address Ard Biesheuvel
2017-06-08 19:41 ` [PATCH 2/2] arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT Ard Biesheuvel
2017-06-09 10:00 ` [PATCH 0/2] arm64: fix crash when reading /proc/kcore Mark Rutland
2017-06-09 18:05 ` Laura Abbott
2017-06-13 2:00 ` Tan Xiaojun
2017-06-13 7:17 ` Ard Biesheuvel
2017-06-13 14:06 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613140620.GA10107@krava \
--to=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).