From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v4] clk: Add Gemini SoC clock controller
Date: Thu, 15 Jun 2017 14:00:20 -0700 [thread overview]
Message-ID: <20170615210020.GG20170@codeaurora.org> (raw)
In-Reply-To: <CACRpkdY+aSyec9PZaoXErzsRefWg2zzw1xihQt_whmote-jBBw@mail.gmail.com>
On 06/15, Linus Walleij wrote:
> On Thu, Jun 15, 2017 at 10:55 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
> > If clocks and resets are provided by the same hardware module, you can
> > have a single (platform) driver registering both the clock and reset
> > controllers.
> > Cfr. drivers/clk/renesas/renesas-cpg-mssr.c.
>
> That is indeed an option.
>
> So I would say, clk & reset maintainers: would you prefer that I merge the
> reset control into the clock driver as well, ask Philipp to drop the pending
> reset control patches from his subsystem tree and have you manage the
> combined driver and bindings?
>
> It seems to me as very ugly from a divide & conquer subsystem and file
> split point of view.
>
> I seems elegant from the "make clocks a platform device" point of view.
>
> I am happy with either approach as long as it works.
>
> I guess it is up to the taste of the subsystem maintainers, especially
> clk.
>
> If I get some time I might just hack this up and send the patches so
> it is on the table as an alternative to the current v5 patch. Certainly it is
> better than going back and augmenting the DT bindings.
>
We have quite a few clock and reset controllers that put their
drivers into the clk directory. I don't see any problem with that
approach.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-15 21:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 8:20 [PATCH 2/2 v4] clk: Add Gemini SoC clock controller Linus Walleij
2017-06-01 7:02 ` Stephen Boyd
2017-06-05 13:34 ` Linus Walleij
2017-06-05 19:58 ` Stephen Boyd
2017-06-08 12:18 ` Linus Walleij
2017-06-12 6:21 ` Linus Walleij
2017-06-12 21:02 ` Stephen Boyd
2017-06-14 11:31 ` Linus Walleij
2017-06-14 15:55 ` Stephen Boyd
2017-06-15 7:16 ` Linus Walleij
2017-06-15 8:55 ` Geert Uytterhoeven
2017-06-15 12:57 ` Linus Walleij
2017-06-15 21:00 ` Stephen Boyd [this message]
2017-06-16 8:35 ` Linus Walleij
2017-06-15 21:55 ` Philipp Zabel
2017-06-16 8:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615210020.GG20170@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).