From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: Applied "ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe'" to the asoc tree
Date: Fri, 16 Jun 2017 10:18:56 +0100 [thread overview]
Message-ID: <20170616091856.jz5d4trm5jz2ugan@sirena.org.uk> (raw)
In-Reply-To: <e92fef8d-5ce1-0b7d-d130-0246d2cb7f91@wanadoo.fr>
On Fri, Jun 16, 2017 at 06:57:30AM +0200, Christophe JAILLET wrote:
> Le 15/06/2017 ? 19:20, Mark Brown a ?crit :
> > if (!of_property_read_u32(node, "rockchip,playback-channels", &val)) {
> > if (val >= 2 && val <= 8)
> > soc_dai->playback.channels_max = val;
> ... and 'err' should be 'ret'...
> I'm really confused for such a ugly proposal !
In a situation like this it's generally best to send a patch, I'll fix
though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170616/09fc6b51/attachment.sig>
prev parent reply other threads:[~2017-06-16 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 5:53 [PATCH] ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe' Christophe JAILLET
2017-06-15 11:38 ` kbuild test robot
2017-06-15 17:20 ` Applied "ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe'" to the asoc tree Mark Brown
2017-06-15 17:32 ` Christophe JAILLET
2017-06-15 19:12 ` Mark Brown
2017-06-16 4:57 ` Christophe JAILLET
2017-06-16 9:18 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616091856.jz5d4trm5jz2ugan@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox