From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Sun, 18 Jun 2017 00:09:25 -0700 Subject: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE In-Reply-To: References: <20170616181059.19206-1-hch@lst.de> <20170616181059.19206-4-hch@lst.de> Message-ID: <20170618070925.GA18526@infradead.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote: > dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what > the compiler is already generating and will save a few lines of code > so what you end up with is something like: Honestly wanted to touch the code as little as possible :) If we want to make it prettier and more readable it needs to be refactored. If you're interested I can take a stab at that, but I'd like to keep it out of this already giant series.