From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by misplaced __printf
Date: Mon, 19 Jun 2017 15:42:09 -0300 [thread overview]
Message-ID: <20170619184209.GB13640@kernel.org> (raw)
In-Reply-To: <CANLsYkyG3E9xiOyJz_5EA0B0oQGsSCy2oW7i1iY5YUxU1imKng@mail.gmail.com>
Em Mon, Jun 19, 2017 at 11:51:20AM -0600, Mathieu Poirier escreveu:
> On 16 June 2017 at 13:59, Kim Phillips <kim.phillips@arm.com> wrote:
> > -static int cs_device__print_file(const char *name, const char *fmt, ...) __printf(2, 3)
> > +static int __printf(2, 3) cs_device__print_file(const char *name, const char *fmt, ...)
> > {
> > va_list args;
> > FILE *file;
>
> I just tested Kim's solution on my side.
>
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks for checking, since I haven't pushed this to Ingo I just squashed
Kim's fix into the buggy cset.
Now I'm trying to build it with lots of cross build containers to see if
there are any other problems before push this up to Ingo.
- Arnaldo
next prev parent reply other threads:[~2017-06-19 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 19:59 [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by misplaced __printf Kim Phillips
2017-06-19 17:51 ` Mathieu Poirier
2017-06-19 18:42 ` Arnaldo Carvalho de Melo [this message]
2017-06-19 19:26 ` Kim Phillips
2017-06-19 19:52 ` Arnaldo Carvalho de Melo
2017-06-19 20:29 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619184209.GB13640@kernel.org \
--to=acme@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).