From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: add bindings for ZTE zx-aud96p22 audio codec
Date: Wed, 21 Jun 2017 21:22:47 +0800 [thread overview]
Message-ID: <20170621132245.GD3372@dragon> (raw)
In-Reply-To: <20170620143352.rjitvgkzh554pviq@sirena.org.uk>
On Tue, Jun 20, 2017 at 03:33:52PM +0100, Mark Brown wrote:
> On Tue, Jun 20, 2017 at 11:11:32AM +0800, Shawn Guo wrote:
> > On Mon, Jun 19, 2017 at 05:16:06PM +0100, Mark Brown wrote:
>
> > > If there's an external power amplifier this is a separate chip to this
> > > CODEC and should therefore be separately controlled and integrated as
> > > part of the machine integration.
>
> > Yes, that should be the best. But we do not have a particular machine
> > driver for our platform, and we are using simple-audio-card driver
>
> You should be switching to the of-graph card now.
Thanks for the info. Will do.
> > instead. I'm not sure if it's generic enough to patch simple-audio-card
> > driver support this pa-gpios, so chose to fold this quick change in the
> > codec driver.
>
> Having a separate amplifier is a completely normal thing, and no matter
> how unusual something is it's obviously not OK to hack one driver to
> support a completely different device.
Okay, I will drop it from codec driver, and try to support it in
audio-graph-card with separate patch later.
Shawn
next prev parent reply other threads:[~2017-06-21 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 14:09 [PATCH 0/2] Add ZTE ZTE zx-aud96p22 audio codec driver Shawn Guo
2017-06-17 14:09 ` [PATCH 1/2] ASoC: add bindings for ZTE zx-aud96p22 audio codec Shawn Guo
2017-06-19 16:16 ` Mark Brown
2017-06-20 3:11 ` Shawn Guo
2017-06-20 14:33 ` Mark Brown
2017-06-21 13:22 ` Shawn Guo [this message]
2017-06-17 14:09 ` [PATCH 2/2] ASoC: zx_aud96p22: add ZTE ZX AUD96P22 codec driver Shawn Guo
2017-06-19 16:19 ` Mark Brown
2017-06-20 3:19 ` Shawn Guo
2017-06-20 12:40 ` Mark Brown
2017-06-21 16:03 ` Shawn Guo
2017-06-21 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621132245.GD3372@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).