linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8] clk: Add Gemini SoC clock controller
Date: Wed, 21 Jun 2017 10:45:40 -0700	[thread overview]
Message-ID: <20170621174540.GB4493@codeaurora.org> (raw)
In-Reply-To: <20170621075952.26387-1-linus.walleij@linaro.org>

On 06/21, Linus Walleij wrote:
> The Cortina Systems Gemini (SL3516/CS3516) has an on-chip clock
> controller that derive all clocks from a single crystal, using some
> documented and some undocumented PLLs, half dividers, counters and
> gates. This is a best attempt to construct a clock driver for the
> clocks so at least we can gate off unused hardware and driver the
> PCI bus clock.
> 
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-next + this fixup

---8<---
diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c
index 3ddd2faec674..b82db96ce0c7 100644
--- a/drivers/clk/clk-gemini.c
+++ b/drivers/clk/clk-gemini.c
@@ -279,13 +279,9 @@ static int gemini_clk_probe(struct platform_device *pdev)
 
 	/* Remap the system controller for the exclusive register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
 	base = devm_ioremap_resource(dev, res);
-	if (!base) {
-		dev_err(dev, "no memory base\n");
-		return -ENODEV;
-	}
+	if (IS_ERR(base))
+		return PTR_ERR(base);
 
 	map = syscon_node_to_regmap(np);
 	if (IS_ERR(map)) {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-06-21 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  7:59 [PATCH v8] clk: Add Gemini SoC clock controller Linus Walleij
2017-06-21 17:45 ` Stephen Boyd [this message]
2017-06-25 22:08   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621174540.GB4493@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).