From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family
Date: Thu, 22 Jun 2017 15:48:33 +0800 [thread overview]
Message-ID: <20170622074831.GA23753@dragon> (raw)
In-Reply-To: <20170620074126.GA1541@katana>
On Tue, Jun 20, 2017 at 09:41:26AM +0200, Wolfram Sang wrote:
> > > How was this driver tested BTW?
> >
> > The driver is being used to access an Audio codec on the I2C bus.
>
> Nice. Can you also run 'i2cdetect' on the bus to see if we have proper
> NAK handling? AFAICS this should be broken now. And very slow with
> previous versions of the driver.
Hmm, it seems that 'i2cdetect' works fine with the driver.
$ i2cdetect -l
i2c-0 i2c zx2967 i2c adapter I2C adapter
$ i2cdetect 0
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-0.
I will probe address range 0x03-0x77.
Continue? [Y/n] Y
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- UU -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- --
50: -- -- -- -- -- -- -- -- -- -- 5a -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: 70 -- -- -- -- -- -- --
$
The audio codec is on address 0x22.
Why do you think it should be broken now?
Shawn
next prev parent reply other threads:[~2017-06-22 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 4:59 [PATCH 0/2] Add I2C driver for ZTE ZX2967 family SoCs Shawn Guo
2017-05-28 4:59 ` [PATCH 1/2] dt: bindings: add documentation for zx2967 family i2c controller Shawn Guo
2017-05-28 4:59 ` [PATCH 2/2] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family Shawn Guo
2017-06-19 19:31 ` Wolfram Sang
2017-06-20 2:58 ` Shawn Guo
2017-06-20 7:41 ` Wolfram Sang
2017-06-21 16:06 ` Shawn Guo
2017-06-22 7:48 ` Shawn Guo [this message]
2017-06-22 8:07 ` Wolfram Sang
2017-06-22 12:25 ` Shawn Guo
2017-06-22 13:22 ` Wolfram Sang
2017-06-10 14:32 ` [PATCH 0/2] Add I2C driver for ZTE ZX2967 family SoCs Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622074831.GA23753@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).