From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/3] Cavium ARM64 uncore PMU support
Date: Fri, 23 Jun 2017 15:56:07 +0200 [thread overview]
Message-ID: <20170623135607.qey6p3pt4fltvyas@pd.tnic> (raw)
In-Reply-To: <20170623130128.11006-1-jglauber@cavium.com>
On Fri, Jun 23, 2017 at 03:01:25PM +0200, Jan Glauber wrote:
> Add support for various PMU counters found on the Cavium ThunderX and
> OcteonTx SoC.
>
> The driver provides common "uncore" functions to avoid code duplication and
> support adding more device PMUs (like L2 cache) in the future.
>
> Probe and removal of the PMUs is done by hooking into the ThunderX EDAC
> driver as this driver owns all the PCI devices containing the PMU counters.
... which is a very bad idea, of course. EDAC doesn't have anything to
do with performance measurements.
And I don't see why the EDAC driver should own any PCI devices -
EDAC simply uses them like anything else in the kernel so the PMU
functionality can simply use them too, independent from EDAC.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2017-06-23 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 13:01 [PATCH v6 0/3] Cavium ARM64 uncore PMU support Jan Glauber
2017-06-23 13:01 ` [PATCH v6 1/3] perf: cavium: Support memory controller PMU counters Jan Glauber
2017-06-23 13:01 ` [PATCH v6 2/3] perf: cavium: Support transmit-link " Jan Glauber
2017-06-23 13:01 ` [PATCH v6 3/3] perf: cavium: Add Documentation Jan Glauber
2017-06-23 13:56 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623135607.qey6p3pt4fltvyas@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox