linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: laurentiu.tudor@nxp.com (laurentiu.tudor at nxp.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/15] staging: fsl-mc: be consistent when checking strcmp() return
Date: Tue, 27 Jun 2017 17:41:22 +0300	[thread overview]
Message-ID: <20170627144135.15599-3-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170627144135.15599-1-laurentiu.tudor@nxp.com>

From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Stick to one way of checking the return code of strcmp(): use '!'.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
v2:
 - new patch

 drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
index 9291847..d34e2ff 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
@@ -19,9 +19,9 @@
 
 static bool __must_check fsl_mc_is_allocatable(const char *obj_type)
 {
-	return strcmp(obj_type, "dpbp") == 0 ||
-	       strcmp(obj_type, "dpmcp") == 0 ||
-	       strcmp(obj_type, "dpcon") == 0;
+	return strcmp(obj_type, "dpbp") ||
+	       strcmp(obj_type, "dpmcp") ||
+	       strcmp(obj_type, "dpcon");
 }
 
 /**
-- 
2.9.4

  parent reply	other threads:[~2017-06-27 14:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 14:41 [PATCH v2 00/15] staging: fsl-mc: clean up header files laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call laurentiu.tudor at nxp.com
2017-06-27 14:41 ` laurentiu.tudor at nxp.com [this message]
2017-06-27 14:41 ` [PATCH v2 03/15] staging: fsl-mc: drop useless #includes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 04/15] staging: fsl-mc: decouple the mc-bus public headers from dprc.h laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 05/15] staging: fsl-mc: delete duplicated function prototypes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 06/15] staging: fsl-mc: delete prototype of unimplemented function laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 07/15] staging: fsl-mc: turn several exported functions static laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 08/15] staging: fsl-mc: move irq domain creation prototype to public header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 09/15] staging: fsl-mc: move couple of definitions " laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 10/15] staging: fsl-mc: move rest of mc-bus.h to private header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 11/15] staging: fsl-mc: remove dpmng API files laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 12/15] staging: fsl-mc: fix a few implicit includes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 13/15] staging: fsl-mc: move mc-sys.h contents in the public header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 14/15] staging: fsl-mc: move mc-cmd.h " laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 15/15] staging: fsl-mc: make dprc.h header private laurentiu.tudor at nxp.com
2017-06-27 15:33 ` [PATCH v2 00/15] staging: fsl-mc: clean up header files Arnd Bergmann
2017-06-27 16:00   ` gregkh
2017-06-27 20:21     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627144135.15599-3-laurentiu.tudor@nxp.com \
    --to=laurentiu.tudor@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).