From: laurentiu.tudor@nxp.com (laurentiu.tudor at nxp.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/15] staging: fsl-mc: turn several exported functions static
Date: Tue, 27 Jun 2017 17:41:27 +0300 [thread overview]
Message-ID: <20170627144135.15599-8-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170627144135.15599-1-laurentiu.tudor@nxp.com>
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
They are never used outside the source they are implemented in and very
likely never will, so it's safe to make them static.
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
v2:
- no changes
drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++-----
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 5 ++---
drivers/staging/fsl-mc/include/mc-bus.h | 8 --------
3 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 329ab10..adf2ffb 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -221,8 +221,8 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev,
* populated before they can get allocation requests from probe callbacks
* of the device drivers for the non-allocatable devices.
*/
-int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
- unsigned int *total_irq_count)
+static int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
+ unsigned int *total_irq_count)
{
int num_child_objects;
int dprc_get_obj_failures;
@@ -310,7 +310,6 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
return 0;
}
-EXPORT_SYMBOL_GPL(dprc_scan_objects);
/**
* dprc_scan_container - Scans a physical DPRC and synchronizes Linux bus state
@@ -321,7 +320,7 @@ EXPORT_SYMBOL_GPL(dprc_scan_objects);
* bus driver with the actual state of the MC by adding and removing
* devices as appropriate.
*/
-int dprc_scan_container(struct fsl_mc_device *mc_bus_dev)
+static int dprc_scan_container(struct fsl_mc_device *mc_bus_dev)
{
int error;
unsigned int irq_count;
@@ -357,7 +356,6 @@ int dprc_scan_container(struct fsl_mc_device *mc_bus_dev)
fsl_mc_cleanup_all_resource_pools(mc_bus_dev);
return error;
}
-EXPORT_SYMBOL_GPL(dprc_scan_container);
/**
* dprc_irq0_handler - Regular ISR for DPRC interrupt 0
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index 8725a5c..60b2a40 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -241,8 +241,8 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
/**
* fsl_mc_get_root_dprc - function to traverse to the root dprc
*/
-void fsl_mc_get_root_dprc(struct device *dev,
- struct device **root_dprc_dev)
+static void fsl_mc_get_root_dprc(struct device *dev,
+ struct device **root_dprc_dev)
{
if (WARN_ON(!dev)) {
*root_dprc_dev = NULL;
@@ -254,7 +254,6 @@ void fsl_mc_get_root_dprc(struct device *dev,
*root_dprc_dev = (*root_dprc_dev)->parent;
}
}
-EXPORT_SYMBOL_GPL(fsl_mc_get_root_dprc);
static int get_dprc_attr(struct fsl_mc_io *mc_io,
int container_id, struct dprc_attributes *attr)
diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index aac062e..c1df433 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -70,11 +70,6 @@ struct fsl_mc_bus {
#define to_fsl_mc_bus(_mc_dev) \
container_of(_mc_dev, struct fsl_mc_bus, mc_dev)
-int dprc_scan_container(struct fsl_mc_device *mc_bus_dev);
-
-int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
- unsigned int *total_irq_count);
-
struct irq_domain *fsl_mc_msi_create_irq_domain(struct fwnode_handle *fwnode,
struct msi_domain_info *info,
struct irq_domain *parent);
@@ -91,9 +86,6 @@ void fsl_mc_init_all_resource_pools(struct fsl_mc_device *mc_bus_dev);
void fsl_mc_cleanup_all_resource_pools(struct fsl_mc_device *mc_bus_dev);
-void fsl_mc_get_root_dprc(struct device *dev,
- struct device **root_dprc_dev);
-
bool fsl_mc_is_root_dprc(struct device *dev);
extern struct bus_type fsl_mc_bus_type;
--
2.9.4
next prev parent reply other threads:[~2017-06-27 14:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 14:41 [PATCH v2 00/15] staging: fsl-mc: clean up header files laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 02/15] staging: fsl-mc: be consistent when checking strcmp() return laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 03/15] staging: fsl-mc: drop useless #includes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 04/15] staging: fsl-mc: decouple the mc-bus public headers from dprc.h laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 05/15] staging: fsl-mc: delete duplicated function prototypes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 06/15] staging: fsl-mc: delete prototype of unimplemented function laurentiu.tudor at nxp.com
2017-06-27 14:41 ` laurentiu.tudor at nxp.com [this message]
2017-06-27 14:41 ` [PATCH v2 08/15] staging: fsl-mc: move irq domain creation prototype to public header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 09/15] staging: fsl-mc: move couple of definitions " laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 10/15] staging: fsl-mc: move rest of mc-bus.h to private header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 11/15] staging: fsl-mc: remove dpmng API files laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 12/15] staging: fsl-mc: fix a few implicit includes laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 13/15] staging: fsl-mc: move mc-sys.h contents in the public header laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 14/15] staging: fsl-mc: move mc-cmd.h " laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 15/15] staging: fsl-mc: make dprc.h header private laurentiu.tudor at nxp.com
2017-06-27 15:33 ` [PATCH v2 00/15] staging: fsl-mc: clean up header files Arnd Bergmann
2017-06-27 16:00 ` gregkh
2017-06-27 20:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627144135.15599-8-laurentiu.tudor@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).