public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: r8a7796: Add DRIF support
Date: Fri, 30 Jun 2017 12:17:20 +0200	[thread overview]
Message-ID: <20170630101720.GH26710@verge.net.au> (raw)
In-Reply-To: <20170627125438.44491-1-ramesh.shanmugasundaram@bp.renesas.com>

On Tue, Jun 27, 2017 at 01:54:38PM +0100, Ramesh Shanmugasundaram wrote:
> Adds the DRIF controller nodes for r8a7796.
> 
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
> Hi Simon,
> 
>    This patch is based on renesas-devel-20170626-v4.12-rc7 tag.
>    It is verified on M3 ES1.0. I also verified there are no regression issues
>    with this addition.
> 
>    The driver[1] is pushed into the media_tree. The bindings[2] are ACK'ed
>    by Geert & Rob and in the media_tree queue.
> 
>    [1] https://git.linuxtv.org/media_tree.git/commit/?id=7625ee981af166ddb569e2e6c0006e2af471326f
>    [2] https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg15602.html
> 
> Thanks,
> Ramesh.
> 
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 120 +++++++++++++++++++++++++++++++
>  1 file changed, 120 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 1f6710912045..df04d132a127 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -639,6 +639,126 @@
>  			};
>  		};
>  
> +		drif00: rif at e6f40000 {
> +			compatible = "renesas,r8a7796-drif",
> +				     "renesas,rcar-gen3-drif";
> +			reg = <0 0xe6f40000 0 0x64>;
> +			interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 515>;
> +			clock-names = "fck";
> +			dmas = <&dmac1 0x20>, <&dmac2 0x20>;

The dmas property seems a little strange. I would have expected to allow
ether dmac1 or dmac2 to be used for both tx and rx:

			dmas = <&dmac1 0x20>, <&dmac1 0x20>,
			       <&dmac2 0x20>, <&dmac2 0x20>;


> +			dma-names = "rx", "rx";
> +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> +			resets = <&cpg 515>;
> +			renesas,bonding = <&drif01>;
> +			status = "disabled";
> +		};

...

  reply	other threads:[~2017-06-30 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 12:54 [PATCH] arm64: dts: r8a7796: Add DRIF support Ramesh Shanmugasundaram
2017-06-30 10:17 ` Simon Horman [this message]
2017-06-30 10:28   ` Ramesh Shanmugasundaram
2017-06-30 11:53     ` Simon Horman
2017-07-05  9:41 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170630101720.GH26710@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox