From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: l2x0: support parity-enable/disable on aurora
Date: Fri, 30 Jun 2017 16:00:14 +0100 [thread overview]
Message-ID: <20170630150013.GY4902@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170630145106.29820-4-jlu@pengutronix.de>
On Fri, Jun 30, 2017 at 04:51:01PM +0200, Jan Luebbe wrote:
> From: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> The aurora cache on the Marvell Armada-XP SoC supports the same tag
> parity features as the other l2x0 cache implementations.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> [jlu at pengutronix.de: use aurora specific define AURORA_ACR_PARITY_EN]
As far as I can see, there is no definition of AURORA_ACR_PARITY_EN in
mainline kernels at the moment, and your patch series (to this point)
does not add it.
The definition for this, and the ECC bit appears to be in patch 8.
This breaks bisection. Please ensure that definitions are added in
patches either before or with the patch that makes use of the new
definition, never afterwards.
Thanks.
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> ---
> arch/arm/mm/cache-l2x0.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index 7d2d2a3c67d0..b70bee74750d 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1505,6 +1505,13 @@ static void __init aurora_of_parse(const struct device_node *np,
> mask |= AURORA_ACR_FORCE_WRITE_POLICY_MASK;
> }
>
> + if (of_property_read_bool(np, "arm,parity-enable")) {
> + mask |= AURORA_ACR_PARITY_EN;
> + val |= AURORA_ACR_PARITY_EN;
> + } else if (of_property_read_bool(np, "arm,parity-disable")) {
> + mask |= AURORA_ACR_PARITY_EN;
> + }
> +
> *aux_val &= ~mask;
> *aux_val |= val;
> *aux_mask &= ~mask;
> --
> 2.11.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-06-30 15:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 14:50 [PATCH 0/8] EDAC drivers for Armada XP L2 and DDR Jan Luebbe
2017-06-30 14:50 ` [PATCH 1/8] ARM: l2c: move cache-aurora-l2.h to asm/hardware Jan Luebbe
2017-07-03 12:50 ` Gregory CLEMENT
2017-06-30 14:51 ` [PATCH 2/8] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Jan Luebbe
2017-07-03 12:51 ` Gregory CLEMENT
2017-06-30 14:51 ` [PATCH 3/8] ARM: l2x0: support parity-enable/disable on aurora Jan Luebbe
2017-06-30 15:00 ` Russell King - ARM Linux [this message]
2017-06-30 14:51 ` [PATCH 4/8] ARM: l2x0: add arm,ecc-enable property for aurora Jan Luebbe
2017-06-30 15:00 ` Russell King - ARM Linux
2017-07-02 22:02 ` Chris Packham
2017-07-17 10:11 ` Jan Lübbe
2017-07-03 13:01 ` Gregory CLEMENT
2017-06-30 14:51 ` [PATCH 5/8] EDAC: Add missing debugfs_create_x32 wrapper Jan Luebbe
2017-06-30 14:51 ` [PATCH 6/8] EDAC: Add devres helpers for edac_mc_alloc/edac_mc_add_mc(_with_groups) Jan Luebbe
2017-06-30 14:51 ` [PATCH 7/8] EDAC: Add devres helpers for edac_device_alloc_ctl_info/edac_device_add_device Jan Luebbe
2017-06-30 14:51 ` [PATCH 8/8] EDAC: Add driver for the Marvell Armada XP SDRAM and L2 cache ECC Jan Luebbe
2017-07-03 13:03 ` Gregory CLEMENT
2017-07-02 21:59 ` [PATCH 0/8] EDAC drivers for Armada XP L2 and DDR Chris Packham
2017-07-17 10:18 ` Jan Lübbe
2017-07-17 10:22 ` Borislav Petkov
2017-07-17 10:51 ` Jan Lübbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630150013.GY4902@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).