From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
Date: Mon, 3 Jul 2017 10:40:22 +0530 [thread overview]
Message-ID: <20170703051022.GZ19154@localhost> (raw)
In-Reply-To: <1498833785-22632-1-git-send-email-okaya@codeaurora.org>
On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
>
> The DMA Engine document clearly states this.
>
> "dmaengine_submit() will not start the DMA operation".
>
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
>
> A descriptor goes through these transitions now.
>
> free->prepared->queued->active->completed->free
>
> as opposed to
>
> free->prepared->active->completed->free
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2017-07-03 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 14:43 [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit Sinan Kaya
2017-07-03 5:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703051022.GZ19154@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).