From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/5] drivers: Add boot constraints core
Date: Mon, 3 Jul 2017 11:45:52 +0530 [thread overview]
Message-ID: <20170703061552.GB3532@vireshk-i7> (raw)
In-Reply-To: <20170630121026.azppihjqls5i6bbr@sirena.org.uk>
On 30-06-17, 13:10, Mark Brown wrote:
> On Fri, Jun 30, 2017 at 02:13:30PM +0530, Viresh Kumar wrote:
> > On 30-06-17, 14:36, Chen-Yu Tsai wrote:
>
> > Operable ranges of the regulator: 1.8 - 3.0 V
> > Range required by LCD: 2.0 - 3.0 V
> > Range required by DMA: 1.8 - 2.5 V
>
> > Here DMA can't work with regulator voltages > 2.5 V, but regulator can
> > go max to 3.0 V. Of course if the DMA driver has done
> > regulator_set_voltage(), then we will be within 2.5 V range. But that
> > doesn't force us to have regulator-max-microvolt set to 2.5 V.
>
> > And so the DT node shall have this:
>
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <3000000>;
>
> > Isn't it ?
>
> If the DMA can't tolerate more than 2.5V then why would the constraints
> allow the voltage to float that far? Similarly on the low end?
The above regulator-min/max-microvolt values I mentioned were for the regulator
device and not what the consumers would request. Yes, DMA will request something
between 1.8 to 2.5 V, but in the above example LCD can request from 2.0 to 3.0 V
and so I had those limits for the regulator device (in DT).
> Please remember that devices shouldn't be managing their voltages unless
> they are actively changing them at runtime, simply setting them at
> startup is the job of the constraints. I would be very surprised to see
> a DMA controller doing anything like DVFS.
Sure, DMA would most likely set a constraint from probe. Maybe I could have used
MMC in the above example, which may actually do DVFS at runtime.
--
viresh
next prev parent reply other threads:[~2017-07-03 6:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 10:26 [RFC 0/5] drivers: Add boot constraints core Viresh Kumar
2017-06-28 10:26 ` [RFC 1/5] " Viresh Kumar
2017-06-28 15:55 ` Randy Dunlap
2017-06-29 3:51 ` Viresh Kumar
2017-06-29 12:50 ` Russell King - ARM Linux
2017-06-29 14:49 ` Viresh Kumar
2017-06-28 10:26 ` [RFC 2/5] drivers: boot_constraint: Add support for supply constraints Viresh Kumar
2017-06-28 10:26 ` [RFC 3/5] drivers: boot_constraint: Add boot_constraints_disable kernel parameter Viresh Kumar
2017-06-28 15:51 ` Randy Dunlap
2017-06-28 10:26 ` [RFC 4/5] drivers: boot_constraint: Add debugfs support Viresh Kumar
2017-06-28 15:46 ` Randy Dunlap
2017-06-29 4:11 ` Viresh Kumar
2017-06-28 10:26 ` [RFC 5/5] drivers: Code to test boot constraints Viresh Kumar
2017-06-29 12:40 ` [RFC 0/5] drivers: Add boot constraints core Enrico Weigelt, metux IT consult
2017-06-29 14:47 ` Viresh Kumar
2017-06-29 15:06 ` Enrico Weigelt, metux IT consult
2017-06-30 3:16 ` Viresh Kumar
2017-06-30 3:33 ` Chen-Yu Tsai
2017-06-30 3:55 ` Viresh Kumar
2017-06-30 4:05 ` Chen-Yu Tsai
2017-06-30 4:12 ` Viresh Kumar
2017-06-30 4:22 ` Chen-Yu Tsai
2017-06-30 5:12 ` Viresh Kumar
2017-06-30 6:36 ` Chen-Yu Tsai
2017-06-30 8:43 ` Viresh Kumar
2017-06-30 12:10 ` Mark Brown
2017-07-03 6:15 ` Viresh Kumar [this message]
2017-07-03 15:07 ` Mark Brown
2017-07-04 6:45 ` Viresh Kumar
2017-06-30 12:12 ` Mark Brown
2017-06-29 12:49 ` Russell King - ARM Linux
2017-06-29 13:05 ` Enrico Weigelt, metux IT consult
2017-06-29 14:58 ` Viresh Kumar
2017-06-29 15:43 ` Russell King - ARM Linux
2017-06-29 21:00 ` Stephen Boyd
2017-07-05 22:07 ` Rob Clark
2017-07-07 22:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703061552.GB3532@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox