public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: quentin.schulz@free-electrons.com (Quentin Schulz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/9] clk: at91: clk-generated: create function to find best_diff
Date: Tue,  4 Jul 2017 13:59:23 +0200	[thread overview]
Message-ID: <20170704115927.32662-6-quentin.schulz@free-electrons.com> (raw)
In-Reply-To: <20170704115927.32662-1-quentin.schulz@free-electrons.com>

The way to find the best_diff and do the appropriate process afterwards
can be re-used.

This patch prepares the driver for an upcoming patch that will allow
clk_generated to determine the rate of the audio_pll.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/clk/at91/clk-generated.c | 41 ++++++++++++++++++++++++++--------------
 1 file changed, 27 insertions(+), 14 deletions(-)

diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
index dab7002937e6..6530a2e7e84d 100644
--- a/drivers/clk/at91/clk-generated.c
+++ b/drivers/clk/at91/clk-generated.c
@@ -99,15 +99,36 @@ clk_generated_recalc_rate(struct clk_hw *hw,
 	return DIV_ROUND_CLOSEST(parent_rate, gck->gckdiv + 1);
 }
 
+static void clk_generated_best_diff(struct clk_rate_request *req,
+				    struct clk_hw *parent,
+				    unsigned long parent_rate, u32 div,
+				    int *best_diff, long *best_rate)
+{
+	unsigned long tmp_rate;
+	int tmp_diff;
+
+	if (!div)
+		tmp_rate = parent_rate;
+	else
+		tmp_rate = parent_rate / div;
+	tmp_diff = abs(req->rate - tmp_rate);
+
+	if (*best_diff < 0 || *best_diff > tmp_diff) {
+		*best_rate = tmp_rate;
+		*best_diff = tmp_diff;
+		req->best_parent_rate = parent_rate;
+		req->best_parent_hw = parent;
+	}
+}
+
 static int clk_generated_determine_rate(struct clk_hw *hw,
 					struct clk_rate_request *req)
 {
 	struct clk_generated *gck = to_clk_generated(hw);
 	struct clk_hw *parent = NULL;
 	long best_rate = -EINVAL;
-	unsigned long tmp_rate, min_rate;
+	unsigned long min_rate;
 	int best_diff = -1;
-	int tmp_diff;
 	int i;
 
 	for (i = 0; i < clk_hw_get_num_parents(hw); i++) {
@@ -125,18 +146,10 @@ static int clk_generated_determine_rate(struct clk_hw *hw,
 			continue;
 
 		div = DIV_ROUND_CLOSEST(parent_rate, req->rate);
-		if (!div)
-			tmp_rate = parent_rate;
-		else
-			tmp_rate = parent_rate / div;
-		tmp_diff = abs(req->rate - tmp_rate);
-
-		if (best_diff < 0 || best_diff > tmp_diff) {
-			best_rate = tmp_rate;
-			best_diff = tmp_diff;
-			req->best_parent_rate = parent_rate;
-			req->best_parent_hw = parent;
-		}
+
+		clk_generated_best_diff(req, parent, parent_rate, div,
+					&best_diff, &best_rate);
+
 
 		if (!best_diff)
 			break;
-- 
2.11.0

  parent reply	other threads:[~2017-07-04 11:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 11:59 [PATCH v2 0/9] add support for Sama5d2 audio PLLs and enable ClassD Quentin Schulz
2017-07-04 11:59 ` [PATCH v2 1/9] clk: at91: clk-generated: remove useless divisor loop Quentin Schulz
2017-07-04 11:59 ` [PATCH v2 2/9] clk: at91: add audio plls to the compatible list in DT binding Quentin Schulz
2017-07-04 11:59 ` [PATCH v2 3/9] clk: at91: add audio pll clock drivers Quentin Schulz
2017-07-04 11:59 ` [PATCH v2 4/9] ARM: dts: at91: sama5d2: add classd nodes Quentin Schulz
2017-07-04 11:59 ` Quentin Schulz [this message]
2017-07-04 11:59 ` [PATCH v2 6/9] clk: at91: clk-generated: make gclk determine audio_pll rate Quentin Schulz
2017-07-04 20:39   ` Boris Brezillon
2017-07-06 15:29   ` Nicolas Ferre
2017-07-06 16:08     ` Alexandre Belloni
2017-07-04 11:59 ` [PATCH v2 7/9] ASoC: atmel-classd: remove aclk clock from DT binding Quentin Schulz
2017-07-07 12:44   ` Mark Brown
2017-07-10  1:02   ` Rob Herring
2017-07-04 11:59 ` [PATCH v2 8/9] ASoC: atmel-classd: remove aclk clock Quentin Schulz
2017-07-07 12:44   ` Mark Brown
2017-07-04 11:59 ` [PATCH v2 9/9] ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704115927.32662-6-quentin.schulz@free-electrons.com \
    --to=quentin.schulz@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox