linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vilhelm.gray@gmail.com (William Breathitt Gray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
Date: Tue, 4 Jul 2017 08:58:51 -0400	[thread overview]
Message-ID: <20170704125851.GA20504@sophia> (raw)
In-Reply-To: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com>

On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote:
>Some of include directives in include/linux/gpio/driver.h are
>unneeded because the header does not need to know the content of
>struct device, irq_chip, etc.  Just declare they are structures.
>
>On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>turned out to be necessary for irq_flow_handler_t and spinlock_t,
>respectively.
>
>Each driver should include what it needs without relying on what is
>implicitly included from <linux/gpio/driver.h>.  This will cut down
>unnecessary header parsing.
>
>Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>---
>
> drivers/gpio/gpio-104-dio-48e.c  |  1 +
> drivers/gpio/gpio-104-idi-48.c   |  1 +
> drivers/gpio/gpio-104-idio-16.c  |  1 +
> drivers/gpio/gpio-pci-idio-16.c  |  2 ++
> drivers/gpio/gpio-ws16c48.c      |  1 +

The changes to the above drivers look fine to me:

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

However, this patch as a whole does too many things; I'd like to see it
split-up logically similar to how Andy Shevchenko suggested in his
reply. That should allow ACKs by respective driver maintainers to be
accounted more properly.

William Breathitt Gray

  parent reply	other threads:[~2017-07-04 12:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04  3:53 [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada
2017-07-04  8:30 ` Charles Keepax
2017-07-04 10:06 ` Andy Shevchenko
2017-07-04 10:39   ` Masahiro Yamada
2017-07-31 13:48   ` Linus Walleij
2017-07-31 14:04     ` Andy Shevchenko
2017-08-01  7:53       ` Linus Walleij
2017-08-01 11:04         ` Andy Shevchenko
2017-08-02  1:19           ` Masahiro Yamada
2017-07-04 12:58 ` William Breathitt Gray [this message]
2017-07-04 15:43   ` Masahiro Yamada
2017-07-04 15:51     ` Andy Shevchenko
2017-07-06  6:13 ` kbuild test robot
2017-07-06  6:15 ` kbuild test robot
2017-08-01 18:57 ` Thor Thayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704125851.GA20504@sophia \
    --to=vilhelm.gray@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).