From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: sun4i-i2s: Get startup to call set_fmt
Date: Wed, 5 Jul 2017 18:02:58 +0200 [thread overview]
Message-ID: <20170705160258.3lzrfmoi4kmbmzb5@flea> (raw)
In-Reply-To: <20170705154324.14565-3-codekipper@gmail.com>
On Wed, Jul 05, 2017 at 05:43:23PM +0200, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> The set_fmt function pointer is called during probing and this is whilst
> the block is disabled. It is over writing the default register values with
> the same settings so isn't noticed.
> This wasn't a problem with the older SoCs but with the desire to reuse as
> much functionlity as possible for the newer devices then set_fmt needs to
> be called whilst the block is enabled.
The driver while the block is disabled will use the cache, and will
flush it when the block is enabled so it won't make any difference.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170705/b044c282/attachment.sig>
next prev parent reply other threads:[~2017-07-05 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 15:43 [PATCH 0/3] ASoC: Add I2S support for Allwinner H3 SoCs codekipper at gmail.com
2017-07-05 15:43 ` [PATCH 1/3] ASoC: sun4i-i2s: Add more quirks for newer SoCs codekipper at gmail.com
2017-07-05 15:43 ` [PATCH 2/3] ASoC: sun4i-i2s: Get startup to call set_fmt codekipper at gmail.com
2017-07-05 16:02 ` Maxime Ripard [this message]
2017-07-05 15:43 ` [PATCH 3/3] ASoC: sun4i-i2s: Add support for H3 codekipper at gmail.com
2017-07-05 16:20 ` Maxime Ripard
2017-07-05 17:49 ` Code Kipper
2017-07-06 2:08 ` [linux-sunxi] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705160258.3lzrfmoi4kmbmzb5@flea \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox