From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: marvell: mcbin: Enable PCIe interface
Date: Wed, 5 Jul 2017 18:44:03 +0100 [thread overview]
Message-ID: <20170705174403.GH4902@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAKv+Gu9DXFDDdx3Vrmo20cRtMcbS-MUa4MF5r-Odje68FinGOw@mail.gmail.com>
On Wed, Jul 05, 2017 at 06:36:53PM +0100, Ard Biesheuvel wrote:
> On 5 July 2017 at 18:16, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> > On Wed, Jul 05, 2017 at 06:13:33PM +0200, Gregory CLEMENT wrote:
> >> Enable the PCIe interface on the MACCHIATOBin board. It is located on
> >> CON12 and is 4 lanes capable.
> >>
> >> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> >
> > Why do you folk at free-electrons like doing half a job all the friggin
> > time?
> >
> > You know I have complete patches for mcbin, but you pointedly won't look
> > at them at all - except when you have a problem and want to test my tree.
> > And even then, you ignore my work (despite testing that it works), and
> > you still recreate my patches.
> >
> > This is really frustrating and insane behaviour on your part.
> >
> > Here's what I have:
> >
> > +&cpm_pcie0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&cpm_pcie_pins>;
> > + num-lanes = <4>;
> > + reset-gpio = <&cpm_gpio1 20 GPIO_ACTIVE_LOW>;
> > + status = "okay";
>
> This needs 'num-viewport = <8>' as well, or the crazy Synopsys DWC
> PCIe driver will happily reconfigure the I/O window at runtime to
> perform config space accesses, without any locking whatsoever.
Thanks for the feedback, I'll integrate that change into my patch, so
it's ready for when I rebase after -rc1.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-07-05 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 16:13 [PATCH] arm64: dts: marvell: mcbin: Enable PCIe interface Gregory CLEMENT
2017-07-05 17:16 ` Russell King - ARM Linux
2017-07-05 17:36 ` Ard Biesheuvel
2017-07-05 17:44 ` Russell King - ARM Linux [this message]
2017-07-06 6:31 ` Jisheng Zhang
2017-07-06 8:39 ` Ard Biesheuvel
2017-07-06 12:10 ` Gregory CLEMENT
2017-07-06 12:41 ` Ard Biesheuvel
2017-07-06 12:55 ` Gregory CLEMENT
2017-07-06 13:10 ` Ard Biesheuvel
2017-07-06 7:18 ` Gregory CLEMENT
2017-07-06 9:01 ` Russell King - ARM Linux
2017-07-06 11:38 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705174403.GH4902@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox