* [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value
@ 2017-07-06 21:58 Gustavo A. R. Silva
2017-07-07 0:56 ` Mark yao
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-06 21:58 UTC (permalink / raw)
To: linux-arm-kernel
The right variable to check here is port, not dp.
This issue was detected using Coccinelle and the following semantic patch:
@@
expression x;
identifier fld;
@@
* x = devm_kzalloc(...);
... when != x == NULL
x->fld
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 14fa1f8..9b0b058 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
continue;
port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
- if (!dp)
+ if (!port)
return -ENOMEM;
port->extcon = extcon;
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value
2017-07-06 21:58 [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value Gustavo A. R. Silva
@ 2017-07-07 0:56 ` Mark yao
2017-07-10 19:04 ` Sean Paul
0 siblings, 1 reply; 4+ messages in thread
From: Mark yao @ 2017-07-07 0:56 UTC (permalink / raw)
To: linux-arm-kernel
On 2017?07?07? 05:58, Gustavo A. R. Silva wrote:
> The right variable to check here is port, not dp.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @@
> expression x;
> identifier fld;
> @@
>
> * x = devm_kzalloc(...);
> ... when != x == NULL
> x->fld
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Thanks for the fix,
Acked-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index 14fa1f8..9b0b058 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
> continue;
>
> port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
> - if (!dp)
> + if (!port)
> return -ENOMEM;
>
> port->extcon = extcon;
--
?ark Yao
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value
2017-07-07 0:56 ` Mark yao
@ 2017-07-10 19:04 ` Sean Paul
2017-07-11 0:44 ` Mark yao
0 siblings, 1 reply; 4+ messages in thread
From: Sean Paul @ 2017-07-10 19:04 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote:
> On 2017?07?07? 05:58, Gustavo A. R. Silva wrote:
> > The right variable to check here is port, not dp.
> >
> > This issue was detected using Coccinelle and the following semantic patch:
> >
> > @@
> > expression x;
> > identifier fld;
> > @@
> >
> > * x = devm_kzalloc(...);
> > ... when != x == NULL
> > x->fld
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Thanks for the fix,
>
> Acked-by: Mark Yao <mark.yao@rock-chips.com>
Hi Mark,
I've applied this patch, but in the future, please apply changes directly
instead of just acking.
If you're unable to apply it for some reason (vacation, etc), please reach out to
one of the -misc maintainers via email or irc so we don't inadvertently lose track
of it on the list.
Sean
>
> > ---
> > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> > index 14fa1f8..9b0b058 100644
> > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> > @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
> > continue;
> > port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
> > - if (!dp)
> > + if (!port)
> > return -ENOMEM;
> > port->extcon = extcon;
>
>
> --
> ?ark Yao
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value
2017-07-10 19:04 ` Sean Paul
@ 2017-07-11 0:44 ` Mark yao
0 siblings, 0 replies; 4+ messages in thread
From: Mark yao @ 2017-07-11 0:44 UTC (permalink / raw)
To: linux-arm-kernel
On 2017?07?11? 03:04, Sean Paul wrote:
> On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote:
>> On 2017?07?07? 05:58, Gustavo A. R. Silva wrote:
>>> The right variable to check here is port, not dp.
>>>
>>> This issue was detected using Coccinelle and the following semantic patch:
>>>
>>> @@
>>> expression x;
>>> identifier fld;
>>> @@
>>>
>>> * x = devm_kzalloc(...);
>>> ... when != x == NULL
>>> x->fld
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> Thanks for the fix,
>>
>> Acked-by: Mark Yao <mark.yao@rock-chips.com>
> Hi Mark,
> I've applied this patch, but in the future, please apply changes directly
> instead of just acking.
>
> If you're unable to apply it for some reason (vacation, etc), please reach out to
> one of the -misc maintainers via email or irc so we don't inadvertently lose track
> of it on the list.
>
> Sean
Hi Sean
Got it, I will do it right next time.
Thanks to inform me this,
>
>>> ---
>>> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
>>> index 14fa1f8..9b0b058 100644
>>> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
>>> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
>>> @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
>>> continue;
>>> port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
>>> - if (!dp)
>>> + if (!port)
>>> return -ENOMEM;
>>> port->extcon = extcon;
>>
>> --
>> ?ark Yao
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
?ark Yao
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-11 0:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-06 21:58 [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value Gustavo A. R. Silva
2017-07-07 0:56 ` Mark yao
2017-07-10 19:04 ` Sean Paul
2017-07-11 0:44 ` Mark yao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).