From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver
Date: Fri, 7 Jul 2017 11:18:38 +0200 [thread overview]
Message-ID: <20170707091838.64phmj2p5qvn3dxc@flea> (raw)
In-Reply-To: <72337BAD-680C-46BC-8DF5-645028E08F65@aosc.io>
On Fri, Jul 07, 2017 at 07:13:30AM +0800, Icenowy Zheng wrote:
>
>
> ? 2017?7?7? GMT+08:00 ??4:50:30, Maxime Ripard <maxime.ripard@free-electrons.com> ??:
> >On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote:
> >> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
> >> SUNXI_FUNCTION(0x0, "gpio_in"),
> >> SUNXI_FUNCTION(0x1, "gpio_out"),
> >> - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */
> >> + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */
> >> + SUNXI_FUNCTION_VARIANT(0x3,
> >> + "pll_lock_dbg",
> >> + PINCTRL_SUN8I_R40)),
> >
> >You have a number of lines where the wrapping is not consistent with
> >the rest, such as this one, but also...
>
> I think this one is because of extraordinary function name.
Since you don't have a comment, I guess that's not really that bad.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170707/9cff9cd6/attachment.sig>
next prev parent reply other threads:[~2017-07-07 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:28 [PATCH 0/2] Last step to working Allwinner R40 pinctrl Icenowy Zheng
2017-07-06 14:28 ` [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Icenowy Zheng
2017-07-06 20:46 ` Maxime Ripard
2017-07-06 23:21 ` [linux-sunxi] " icenowy at aosc.io
2017-07-10 8:44 ` Maxime Ripard
2017-07-10 10:23 ` Icenowy Zheng
2017-07-06 14:28 ` [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 " Icenowy Zheng
2017-07-06 20:50 ` Maxime Ripard
2017-07-06 23:13 ` Icenowy Zheng
2017-07-07 9:18 ` Maxime Ripard [this message]
2017-07-07 9:21 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707091838.64phmj2p5qvn3dxc@flea \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).