* [PATCH 0/3] Add MMCIF0 support for r8a7743/iwg20m
@ 2017-07-12 10:03 Chris Paterson
2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson
` (2 more replies)
0 siblings, 3 replies; 21+ messages in thread
From: Chris Paterson @ 2017-07-12 10:03 UTC (permalink / raw)
To: linux-arm-kernel
This series adds MMCIF0 support for the r8a7743 SoC and the iWave-RZG1M-20M
Qseven SOM.
This series is based on renesas-devel-20170711-v4.12.
Chris Paterson (3):
dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings
ARM: dts: r8a7743: Add MMCIF0 support
ARM: dts: iwg20m: Add MMCIF0 support
.../devicetree/bindings/mmc/renesas,mmcif.txt | 3 ++-
arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 26 ++++++++++++++++++++++
arch/arm/boot/dts/r8a7743.dtsi | 16 +++++++++++++
3 files changed, 44 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-12 10:03 [PATCH 0/3] Add MMCIF0 support for r8a7743/iwg20m Chris Paterson @ 2017-07-12 10:03 ` Chris Paterson 2017-07-12 11:20 ` Geert Uytterhoeven 2017-07-13 10:06 ` Ulf Hansson 2017-07-12 10:03 ` [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support Chris Paterson 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson 2 siblings, 2 replies; 21+ messages in thread From: Chris Paterson @ 2017-07-12 10:03 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt index c32dc5a..703e18c 100644 --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt @@ -11,6 +11,7 @@ Required properties: - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs - "renesas,mmcif-r8a73a4" for the MMCIF found in r8a73a4 SoCs - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs + - "renesas,mmcif-r8a7743" for the MMCIF found in r8a7743 SoCs - "renesas,mmcif-r8a7778" for the MMCIF found in r8a7778 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs @@ -21,7 +22,7 @@ Required properties: - interrupts: Some SoCs have only 1 shared interrupt, while others have either 2 or 3 individual interrupts (error, int, card detect). Below is the number of interrupts for each SoC: - 1: r8a73a4, r8a7778, r8a7790, r8a7791, r8a7793, r8a7794 + 1: r8a73a4, r8a7743, r8a7778, r8a7790, r8a7791, r8a7793, r8a7794 2: r8a7740, sh73a0 3: r7s72100 -- 1.9.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson @ 2017-07-12 11:20 ` Geert Uytterhoeven 2017-07-13 7:54 ` Simon Horman 2017-07-13 10:06 ` Ulf Hansson 1 sibling, 1 reply; 21+ messages in thread From: Geert Uytterhoeven @ 2017-07-12 11:20 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-12 11:20 ` Geert Uytterhoeven @ 2017-07-13 7:54 ` Simon Horman 2017-07-13 8:00 ` Geert Uytterhoeven 0 siblings, 1 reply; 21+ messages in thread From: Simon Horman @ 2017-07-13 7:54 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 12, 2017 at 01:20:07PM +0200, Geert Uytterhoeven wrote: > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > <chris.paterson2@renesas.com> wrote: > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied for v4.14. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-13 7:54 ` Simon Horman @ 2017-07-13 8:00 ` Geert Uytterhoeven 2017-07-13 8:07 ` Simon Horman 0 siblings, 1 reply; 21+ messages in thread From: Geert Uytterhoeven @ 2017-07-13 8:00 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Thu, Jul 13, 2017 at 9:54 AM, Simon Horman <horms@verge.net.au> wrote: > On Wed, Jul 12, 2017 at 01:20:07PM +0200, Geert Uytterhoeven wrote: >> On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson >> <chris.paterson2@renesas.com> wrote: >> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thanks, applied for v4.14. Shouldn't this be applied by Ulf to the MMC tree? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-13 8:00 ` Geert Uytterhoeven @ 2017-07-13 8:07 ` Simon Horman 0 siblings, 0 replies; 21+ messages in thread From: Simon Horman @ 2017-07-13 8:07 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 13, 2017 at 10:00:11AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Jul 13, 2017 at 9:54 AM, Simon Horman <horms@verge.net.au> wrote: > > On Wed, Jul 12, 2017 at 01:20:07PM +0200, Geert Uytterhoeven wrote: > >> On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > >> <chris.paterson2@renesas.com> wrote: > >> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > >> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thanks, applied for v4.14. > > Shouldn't this be applied by Ulf to the MMC tree? Sorry, my bad. I have dropped this from the renesas tree. Ulf, please consider this patch for the mmc tree. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings 2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson 2017-07-12 11:20 ` Geert Uytterhoeven @ 2017-07-13 10:06 ` Ulf Hansson 1 sibling, 0 replies; 21+ messages in thread From: Ulf Hansson @ 2017-07-13 10:06 UTC (permalink / raw) To: linux-arm-kernel On 12 July 2017 at 12:03, Chris Paterson <chris.paterson2@renesas.com> wrote: > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > index c32dc5a..703e18c 100644 > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > @@ -11,6 +11,7 @@ Required properties: > - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs > - "renesas,mmcif-r8a73a4" for the MMCIF found in r8a73a4 SoCs > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs > + - "renesas,mmcif-r8a7743" for the MMCIF found in r8a7743 SoCs > - "renesas,mmcif-r8a7778" for the MMCIF found in r8a7778 SoCs > - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs > - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs > @@ -21,7 +22,7 @@ Required properties: > - interrupts: Some SoCs have only 1 shared interrupt, while others have either > 2 or 3 individual interrupts (error, int, card detect). Below is the number > of interrupts for each SoC: > - 1: r8a73a4, r8a7778, r8a7790, r8a7791, r8a7793, r8a7794 > + 1: r8a73a4, r8a7743, r8a7778, r8a7790, r8a7791, r8a7793, r8a7794 > 2: r8a7740, sh73a0 > 3: r7s72100 > > -- > 1.9.1 > Thanks, applied for next! Kind regards Uffe ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support 2017-07-12 10:03 [PATCH 0/3] Add MMCIF0 support for r8a7743/iwg20m Chris Paterson 2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson @ 2017-07-12 10:03 ` Chris Paterson 2017-07-12 11:21 ` Geert Uytterhoeven 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson 2 siblings, 1 reply; 21+ messages in thread From: Chris Paterson @ 2017-07-12 10:03 UTC (permalink / raw) To: linux-arm-kernel Add the MMCIF0 device to the r8a7743 device tree. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 0d02191..f62e858 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -641,6 +641,22 @@ #size-cells = <0>; status = "disabled"; }; + + mmcif0: mmc at ee200000 { + compatible = "renesas,mmcif-r8a7743", + "renesas,sh-mmcif"; + reg = <0 0xee200000 0 0x80>; + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 315>; + dmas = <&dmac0 0xd1>, <&dmac0 0xd2>, + <&dmac1 0xd1>, <&dmac1 0xd2>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 315>; + reg-io-width = <4>; + max-frequency = <97500000>; + status = "disabled"; + }; }; /* External root clock */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support 2017-07-12 10:03 ` [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support Chris Paterson @ 2017-07-12 11:21 ` Geert Uytterhoeven 2017-07-13 7:59 ` Simon Horman 0 siblings, 1 reply; 21+ messages in thread From: Geert Uytterhoeven @ 2017-07-12 11:21 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > Add the MMCIF0 device to the r8a7743 device tree. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support 2017-07-12 11:21 ` Geert Uytterhoeven @ 2017-07-13 7:59 ` Simon Horman 0 siblings, 0 replies; 21+ messages in thread From: Simon Horman @ 2017-07-13 7:59 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 12, 2017 at 01:21:20PM +0200, Geert Uytterhoeven wrote: > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > <chris.paterson2@renesas.com> wrote: > > Add the MMCIF0 device to the r8a7743 device tree. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied for v4.14. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-12 10:03 [PATCH 0/3] Add MMCIF0 support for r8a7743/iwg20m Chris Paterson 2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson 2017-07-12 10:03 ` [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support Chris Paterson @ 2017-07-12 10:03 ` Chris Paterson 2017-07-12 11:52 ` Geert Uytterhoeven ` (2 more replies) 2 siblings, 3 replies; 21+ messages in thread From: Chris Paterson @ 2017-07-12 10:03 UTC (permalink / raw) To: linux-arm-kernel Define the iwg20m board dependent part of the MMCIF0 device node. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi index 001ca91..ffce1b6 100644 --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi @@ -22,8 +22,34 @@ device_type = "memory"; reg = <2 0x00000000 0 0x20000000>; }; + + reg_3p3v: 3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + regulator-boot-on; + }; }; &extal_clk { clock-frequency = <20000000>; }; + +&pfc { + mmcif0_pins: mmc { + groups = "mmc_data8", "mmc_ctrl"; + function = "mmc"; + }; +}; + +&mmcif0 { + pinctrl-0 = <&mmcif0_pins>; + pinctrl-names = "default"; + + vmmc-supply = <®_3p3v>; + bus-width = <8>; + non-removable; + status = "okay"; +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson @ 2017-07-12 11:52 ` Geert Uytterhoeven 2017-07-13 8:02 ` Simon Horman 2017-07-13 0:25 ` kbuild test robot 2017-07-13 15:39 ` [PATCH v2] " Chris Paterson 2 siblings, 1 reply; 21+ messages in thread From: Geert Uytterhoeven @ 2017-07-12 11:52 UTC (permalink / raw) To: linux-arm-kernel Hi Chris, On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > Define the iwg20m board dependent part of the MMCIF0 device node. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > index 001ca91..ffce1b6 100644 > --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > +&pfc { > + mmcif0_pins: mmc { > + groups = "mmc_data8", "mmc_ctrl"; "mmc_data8" is not correct, as D6/D7 of the eMMC are not connected to GP6_28 resp. GP6_29, but to GP6_6 resp. GP6_7. So it should be "mmc_data8_b". Unfortunately the latter pin group isn't supported by the PFC driver yet. Cooking a patch... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-12 11:52 ` Geert Uytterhoeven @ 2017-07-13 8:02 ` Simon Horman 2017-07-13 8:12 ` Simon Horman 0 siblings, 1 reply; 21+ messages in thread From: Simon Horman @ 2017-07-13 8:02 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 12, 2017 at 01:52:49PM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > <chris.paterson2@renesas.com> wrote: > > Define the iwg20m board dependent part of the MMCIF0 device node. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > index 001ca91..ffce1b6 100644 > > --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > +&pfc { > > + mmcif0_pins: mmc { > > + groups = "mmc_data8", "mmc_ctrl"; > > "mmc_data8" is not correct, as D6/D7 of the eMMC are not connected to GP6_28 > resp. GP6_29, but to GP6_6 resp. GP6_7. > So it should be "mmc_data8_b". > > Unfortunately the latter pin group isn't supported by the PFC driver yet. > Cooking a patch... The above notwithstanding I have applied this patch for v4.14. This is under the assumption that: a) the relevant (pfc) driver changes will appear in v4.14 and; b) there is no regression introduced in having this change present without the driver changes An implication of the above is that the new feature will not work until both the driver and DTS changes are in the same tree. But that the trees with each of those changes continue to work at least as well as they did before. Please test the devel branch that I push later today to make sure there are no regressions. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 8:02 ` Simon Horman @ 2017-07-13 8:12 ` Simon Horman 2017-07-13 9:28 ` Chris Paterson 0 siblings, 1 reply; 21+ messages in thread From: Simon Horman @ 2017-07-13 8:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 13, 2017 at 10:02:29AM +0200, Simon Horman wrote: > On Wed, Jul 12, 2017 at 01:52:49PM +0200, Geert Uytterhoeven wrote: > > Hi Chris, > > > > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > > <chris.paterson2@renesas.com> wrote: > > > Define the iwg20m board dependent part of the MMCIF0 device node. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > > > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > index 001ca91..ffce1b6 100644 > > > --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > > > +&pfc { > > > + mmcif0_pins: mmc { > > > + groups = "mmc_data8", "mmc_ctrl"; > > > > "mmc_data8" is not correct, as D6/D7 of the eMMC are not connected to GP6_28 > > resp. GP6_29, but to GP6_6 resp. GP6_7. > > So it should be "mmc_data8_b". > > > > Unfortunately the latter pin group isn't supported by the PFC driver yet. > > Cooking a patch... > > The above notwithstanding I have applied this patch for v4.14. ... Sorry, I think I need more coffee. I misread Geert's comment above. I have dropped this patch. Please post a corrected v2 of this patch. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 8:12 ` Simon Horman @ 2017-07-13 9:28 ` Chris Paterson 0 siblings, 0 replies; 21+ messages in thread From: Chris Paterson @ 2017-07-13 9:28 UTC (permalink / raw) To: linux-arm-kernel > From: Simon Horman [mailto:horms at verge.net.au] > Sent: 13 July 2017 09:12 > > On Thu, Jul 13, 2017 at 10:02:29AM +0200, Simon Horman wrote: > > On Wed, Jul 12, 2017 at 01:52:49PM +0200, Geert Uytterhoeven wrote: > > > Hi Chris, > > > > > > On Wed, Jul 12, 2017 at 12:03 PM, Chris Paterson > > > <chris.paterson2@renesas.com> wrote: > > > > Define the iwg20m board dependent part of the MMCIF0 device node. > > > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > > b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > > index 001ca91..ffce1b6 100644 > > > > --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi > > > > > > > +&pfc { > > > > + mmcif0_pins: mmc { > > > > + groups = "mmc_data8", "mmc_ctrl"; > > > > > > "mmc_data8" is not correct, as D6/D7 of the eMMC are not connected > > > to GP6_28 resp. GP6_29, but to GP6_6 resp. GP6_7. > > > So it should be "mmc_data8_b". > > > > > > Unfortunately the latter pin group isn't supported by the PFC driver yet. > > > Cooking a patch... Thanks for your review Geert. Sorry I missed this. > > > > The above notwithstanding I have applied this patch for v4.14. > > ... > > Sorry, I think I need more coffee. No worries! > > I misread Geert's comment above. I have dropped this patch. > Please post a corrected v2 of this patch. Will do. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson 2017-07-12 11:52 ` Geert Uytterhoeven @ 2017-07-13 0:25 ` kbuild test robot 2017-07-13 7:54 ` Simon Horman 2017-07-13 15:39 ` [PATCH v2] " Chris Paterson 2 siblings, 1 reply; 21+ messages in thread From: kbuild test robot @ 2017-07-13 0:25 UTC (permalink / raw) To: linux-arm-kernel Hi Chris, [auto build test ERROR on renesas/next] [also build test ERROR on next-20170712] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Paterson/Add-MMCIF0-support-for-r8a7743-iwg20m/20170713-042814 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/r8a7743-iwg20m.dtsi:40.1-5 Label or path pfc not found FATAL ERROR: Syntax error parsing input tree --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -------------- next part -------------- A non-text attachment was scrubbed... Name: .config.gz Type: application/gzip Size: 22761 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170713/a6646c4c/attachment-0001.gz> ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 0:25 ` kbuild test robot @ 2017-07-13 7:54 ` Simon Horman 2017-07-13 8:46 ` [kbuild-all] " Ye Xiaolong 0 siblings, 1 reply; 21+ messages in thread From: Simon Horman @ 2017-07-13 7:54 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 13, 2017 at 08:25:56AM +0800, kbuild test robot wrote: > Hi Chris, > > [auto build test ERROR on renesas/next] > [also build test ERROR on next-20170712] > [cannot apply to v4.12] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Chris-Paterson/Add-MMCIF0-support-for-r8a7743-iwg20m/20170713-042814 > base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next > config: arm-at91_dt_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > >> Error: arch/arm/boot/dts/r8a7743-iwg20m.dtsi:40.1-5 Label or path pfc not found > FATAL ERROR: Syntax error parsing input tree This seems to be a false positive. The node in question is present in the devel branch which is the base of these changes. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [kbuild-all] [PATCH 3/3] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 7:54 ` Simon Horman @ 2017-07-13 8:46 ` Ye Xiaolong 0 siblings, 0 replies; 21+ messages in thread From: Ye Xiaolong @ 2017-07-13 8:46 UTC (permalink / raw) To: linux-arm-kernel On 07/13, Simon Horman wrote: >On Thu, Jul 13, 2017 at 08:25:56AM +0800, kbuild test robot wrote: >> Hi Chris, >> >> [auto build test ERROR on renesas/next] >> [also build test ERROR on next-20170712] >> [cannot apply to v4.12] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Chris-Paterson/Add-MMCIF0-support-for-r8a7743-iwg20m/20170713-042814 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next >> config: arm-at91_dt_defconfig (attached as .config) >> compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 >> reproduce: >> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> make.cross ARCH=arm >> >> All errors (new ones prefixed by >>): >> >> >> Error: arch/arm/boot/dts/r8a7743-iwg20m.dtsi:40.1-5 Label or path pfc not found >> FATAL ERROR: Syntax error parsing input tree > >This seems to be a false positive. The node in question is present in >the devel branch which is the base of these changes. Thanks for the feedback, we'll update 0day's configuration accordingly. Thanks, Xiaolong > > >_______________________________________________ >kbuild-all mailing list >kbuild-all at lists.01.org >https://lists.01.org/mailman/listinfo/kbuild-all ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson 2017-07-12 11:52 ` Geert Uytterhoeven 2017-07-13 0:25 ` kbuild test robot @ 2017-07-13 15:39 ` Chris Paterson 2017-07-13 16:31 ` Geert Uytterhoeven 2 siblings, 1 reply; 21+ messages in thread From: Chris Paterson @ 2017-07-13 15:39 UTC (permalink / raw) To: linux-arm-kernel Define the iwg20m board dependent part of the MMCIF0 device node. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> --- This patch is based on: renesas-devel-20170713-v4.12 + pinctrl: sh-pfc: r8a7791: Add R8A7743 support + pinctrl: sh-pfc: r8a7791: Add missing mmc_data8_b pin group v1->v2: - Corrected data pin group to mmc_data8_b - Thanks Geert. arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi index 001ca91..f78dbc5 100644 --- a/arch/arm/boot/dts/r8a7743-iwg20m.dtsi +++ b/arch/arm/boot/dts/r8a7743-iwg20m.dtsi @@ -22,8 +22,34 @@ device_type = "memory"; reg = <2 0x00000000 0 0x20000000>; }; + + reg_3p3v: 3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + regulator-boot-on; + }; }; &extal_clk { clock-frequency = <20000000>; }; + +&pfc { + mmcif0_pins: mmc { + groups = "mmc_data8_b", "mmc_ctrl"; + function = "mmc"; + }; +}; + +&mmcif0 { + pinctrl-0 = <&mmcif0_pins>; + pinctrl-names = "default"; + + vmmc-supply = <®_3p3v>; + bus-width = <8>; + non-removable; + status = "okay"; +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 15:39 ` [PATCH v2] " Chris Paterson @ 2017-07-13 16:31 ` Geert Uytterhoeven 2017-07-14 7:33 ` Simon Horman 0 siblings, 1 reply; 21+ messages in thread From: Geert Uytterhoeven @ 2017-07-13 16:31 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 13, 2017 at 5:39 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > Define the iwg20m board dependent part of the MMCIF0 device node. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > v1->v2: > - Corrected data pin group to mmc_data8_b - Thanks Geert. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: iwg20m: Add MMCIF0 support 2017-07-13 16:31 ` Geert Uytterhoeven @ 2017-07-14 7:33 ` Simon Horman 0 siblings, 0 replies; 21+ messages in thread From: Simon Horman @ 2017-07-14 7:33 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 13, 2017 at 06:31:33PM +0200, Geert Uytterhoeven wrote: > On Thu, Jul 13, 2017 at 5:39 PM, Chris Paterson > <chris.paterson2@renesas.com> wrote: > > Define the iwg20m board dependent part of the MMCIF0 device node. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied for v4.14. ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2017-07-14 7:33 UTC | newest] Thread overview: 21+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-12 10:03 [PATCH 0/3] Add MMCIF0 support for r8a7743/iwg20m Chris Paterson 2017-07-12 10:03 ` [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings Chris Paterson 2017-07-12 11:20 ` Geert Uytterhoeven 2017-07-13 7:54 ` Simon Horman 2017-07-13 8:00 ` Geert Uytterhoeven 2017-07-13 8:07 ` Simon Horman 2017-07-13 10:06 ` Ulf Hansson 2017-07-12 10:03 ` [PATCH 2/3] ARM: dts: r8a7743: Add MMCIF0 support Chris Paterson 2017-07-12 11:21 ` Geert Uytterhoeven 2017-07-13 7:59 ` Simon Horman 2017-07-12 10:03 ` [PATCH 3/3] ARM: dts: iwg20m: " Chris Paterson 2017-07-12 11:52 ` Geert Uytterhoeven 2017-07-13 8:02 ` Simon Horman 2017-07-13 8:12 ` Simon Horman 2017-07-13 9:28 ` Chris Paterson 2017-07-13 0:25 ` kbuild test robot 2017-07-13 7:54 ` Simon Horman 2017-07-13 8:46 ` [kbuild-all] " Ye Xiaolong 2017-07-13 15:39 ` [PATCH v2] " Chris Paterson 2017-07-13 16:31 ` Geert Uytterhoeven 2017-07-14 7:33 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).