public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
Date: Thu, 13 Jul 2017 16:57:21 +0800	[thread overview]
Message-ID: <20170713085720.GX3172@dragon> (raw)
In-Reply-To: <AM3PR04MB14896986FF8C5A18C2643C29F1AC0@AM3PR04MB1489.eurprd04.prod.outlook.com>

On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > index b497ac1..8aa2dcf 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > @@ -411,6 +411,23 @@
> > >  				 <&clockgen 4 3>;
> > >  		};
> > >
> > > +		usb0: usb3 at 2f00000 {
> > > +			compatible = "snps,dwc3";
> > > +			reg = <0x0 0x2f00000 0x0 0x10000>;
> > > +			interrupts = <0 60 0x4>;
> > > +			dr_mode = "host";
> > > +			snps,quirk-frame-length-adjustment = <0x20>;
> > > +			snps,dis_rxdet_inp3_quirk;
> > > +		};
> > > +
> > > +		usb1: usb2 at 8600000 {
> > > +			compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > > +			reg = <0x0 0x8600000 0x0 0x1000>;
> > > +			interrupts = <0 139 0x4>;
> > > +			dr_mode = "host";
> > > +			phy_type = "ulpi";
> > > +		};
> > 
> > Please keep the nodes sorted in unit-address.
> > 
> > Shawn
> Do you mean to move the node 'usb1: usb2 at 8600000' forward to where it's address is just before  '@8600000 '?
> I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.

The nodes under simple-bus are maintained in order of unit-address.
Please respect that.

usb2 at 8600000 should go after sata at 3200000 with the current nodes.

Shawn

> > > +
> > >  		sata: sata at 3200000 {
> > >  			compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > >  			reg = <0x0 0x3200000 0x0 0x10000>,
> > > --
> > > 2.1.0.27.g96db324
> > >

      reply	other threads:[~2017-07-13  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  2:54 [PATCH] arm64: dts: ls1012a: add USB host controller nodes Ran Wang
2017-07-13  8:07 ` Shawn Guo
2017-07-13  8:46   ` Ran Wang
2017-07-13  8:57     ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713085720.GX3172@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox