From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX 6 and PCIe DMA issues
Date: Thu, 13 Jul 2017 10:04:23 +0100 [thread overview]
Message-ID: <20170713090423.GA31807@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170713070718.GA3871@mmlinux>
On Thu, Jul 13, 2017 at 09:07:19AM +0200, michael.moese at men.de wrote:
> Ok, I hope I am correct. I alloc my memory using dma_alloc_coherent()
> once, the dma_handle is passed to the device, with no other dma_map*()
> or dma_sync_*() calls needed?
Correct.
> Yesterday I observed some strange behavior when I did some debug prints in
> the driver, printing me the result from phys_to_virt() of my
> virtual address and the dma_handle. I know these may be different, but,
> when I dump the memory (from userspace using mmap), I can see the data
> at the adress of my dma_handle, but the memory the driver has the
> pointer for has different contents. I don't understand this.
phys_to_virt() and virt_to_phys() are only defined for the linear map
region.
DMA coherent allocations may or may not return addresses in the linear
region, which means virt_to_phys() on a virtual address returned from
dma_alloc_coherent() is not defined.
DMA addresses are not physical addresses, they are device addresses -
this is an important distinction when IOMMUs or address translators are
in the path between the device and memory. phys_to_virt() must not be
used with dma_addr_t data types.
You must always use the two addresses returned from dma_alloc_coherent()
and never try to translate them - the DMA address is for programming
into the hardware, and the virtual address for CPU accesses. If you do
try to pass these to the various translators (like virt_to_phys()) the
result is undefined.
Moreover, passing the dma_addr_t returned from dma_alloc_coherent() to
the dma_sync_*() functions also results in undefined behaviour, and
potential data corruption.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-07-13 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 13:40 i.MX 6 and PCIe DMA issues Moese, Michael
2017-07-11 14:07 ` Andrew Lunn
2017-07-11 14:50 ` Robin Murphy
2017-07-13 7:07 ` michael.moese at men.de
2017-07-13 9:04 ` Russell King - ARM Linux [this message]
2017-07-13 10:00 ` michael.moese at men.de
2017-07-13 10:18 ` Russell King - ARM Linux
2017-07-13 14:57 ` Robin Murphy
2017-07-14 11:07 ` michael.moese at men.de
2017-07-11 17:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713090423.GA31807@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).