[RFC] PCI: dwc: designware: allow customize unroll registers' readl/writel

[RFC] PCI: dwc: designware: allow customize unroll registers' readl/writel

[Jisheng Zhang]

Hi Joao, Jingoo,

Now, the PCIE_GET_ATU_OUTB_UNR_REG_OFFSET macro is defined as:

/* Register address builder */
#define PCIE_GET_ATU_OUTB_UNR_REG_OFFSET(region)        \
                        ((0x3 << 20) | ((region) << 9))

I have one question: where does the (0x3 << 20) come from? 2MB space, a bit
large. And I didn't find it in the databook. Is it platform specific?
If yes, I want to cook one patch to customize unroll registers' readl/writel.

And how does (0x3 << 20) enable DBI2 access?

Thanks in advance,
Jisheng

[RFC] PCI: dwc: designware: allow customize unroll registers' readl/writel

[Jisheng Zhang]

On Thu, 13 Jul 2017 18:48:37 +0800 Jisheng Zhang wrote:

> Hi Joao, Jingoo,
> 
> Now, the PCIE_GET_ATU_OUTB_UNR_REG_OFFSET macro is defined as:
> 
> /* Register address builder */
> #define PCIE_GET_ATU_OUTB_UNR_REG_OFFSET(region)        \
>                         ((0x3 << 20) | ((region) << 9))
> 
> I have one question: where does the (0x3 << 20) come from? 2MB space, a bit

sorry, typo. (0x3 << 20) should be 3MB.

> large. And I didn't find it in the databook. Is it platform specific?
> If yes, I want to cook one patch to customize unroll registers' readl/writel.
> 
> And how does (0x3 << 20) enable DBI2 access?
> 
> Thanks in advance,
> Jisheng

[RFC] PCI: dwc: designware: allow customize unroll registers' readl/writel

[Joao Pinto]

Hi Jisheng,

?s 11:52 AM de 7/13/2017, Jisheng Zhang escreveu:
> On Thu, 13 Jul 2017 18:48:37 +0800 Jisheng Zhang wrote:
> 
>> Hi Joao, Jingoo,
>>
>> Now, the PCIE_GET_ATU_OUTB_UNR_REG_OFFSET macro is defined as:
>>
>> /* Register address builder */
>> #define PCIE_GET_ATU_OUTB_UNR_REG_OFFSET(region)        \
>>                         ((0x3 << 20) | ((region) << 9))
>>
>> I have one question: where does the (0x3 << 20) come from? 2MB space, a bit

From, the PCIe Core 4.80 you have the new feature Unroll, which was developed
for both iATU and DMA.
To inform the Core that you want to access an Unroll register address, bits 20
and 21 must be set, and thats where 0x3 comes from.

If it is not clear please let me know.

> 
> sorry, typo. (0x3 << 20) should be 3MB.
> 
>> large. And I didn't find it in the databook. Is it platform specific?
>> If yes, I want to cook one patch to customize unroll registers' readl/writel.
>>
>> And how does (0x3 << 20) enable DBI2 access?
>>
>> Thanks in advance,
>> Jisheng
> 

Thanks,
Joao