Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool
Date: Fri, 14 Jul 2017 16:09:55 +0300	[thread overview]
Message-ID: <20170714130955.zqe26g6zpixr3xj2@mwanda> (raw)
In-Reply-To: <20170714125525.kjemhcn4poon6r3i@mwanda>

On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
> I don't agree with it as a static analysis dev...

What I mean is if it's a macro that returns -ENODEV or a function that
returns -ENODEV, they should both be treated the same.  The other
warnings this check prints are quite clever.

regards,
dan carpenter

  reply	other threads:[~2017-07-14 13:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170714092540.1217397-1-arnd@arndb.de>
2017-07-14  9:36 ` [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool Arnd Bergmann
2017-07-14 12:05   ` Dan Carpenter
2017-07-14 12:27     ` Arnd Bergmann
2017-07-14 12:55       ` Dan Carpenter
2017-07-14 13:09         ` Dan Carpenter [this message]
2017-07-14 19:32           ` Arnd Bergmann
2017-07-14 12:41   ` Dan Carpenter
2017-07-17 13:45   ` Hans Verkuil
2017-07-17 14:26     ` Arnd Bergmann
2017-07-17 14:28       ` Dan Carpenter
2017-07-17 14:32       ` Hans Verkuil
2017-07-17 14:35       ` Hans Verkuil
2017-07-17 21:23         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170714130955.zqe26g6zpixr3xj2@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox