From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip/gic: Use GIC_SPI symbolic constant
Date: Mon, 17 Jul 2017 10:07:32 +0200 [thread overview]
Message-ID: <20170717100732.435116c8@windsurf> (raw)
In-Reply-To: <86h8ycytse.fsf@arm.com>
Hello,
On Sun, 16 Jul 2017 22:08:01 +0100, Marc Zyngier wrote:
> > Are you saying that changing the code at this point is
> > not worth the trouble?
>
> You're assuming that this GIC_SPI macro has anything to do with the GIC
> driver. It doesn't. That's just a convenience macro for people writing
> DT, and definitely not something I'd ever want to rely on in the Linux
> driver. The binding defines the raw value, and not this macro.
>
> So to sum it up, thank you, but no thank out.
FWIW, a few drivers are already using GIC_SPI:
irq-mvebu-gicp.c: fwspec.param[0] = GIC_SPI;
irq-mvebu-odmi.c: fwspec.param[0] = GIC_SPI;
irq-tegra.c: if (fwspec->param[0] != GIC_SPI)
irq-vf610-mscm-ir.c: parent_fwspec.param[0] = GIC_SPI;
For pretty much exactly the situation being patched by Mason.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-17 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 17:40 [PATCH] irqchip/gic: Use GIC_SPI symbolic constant Mason
2017-07-16 20:13 ` Marc Zyngier
2017-07-16 20:50 ` Mason
2017-07-16 21:08 ` Marc Zyngier
2017-07-16 21:29 ` Mason
2017-07-17 8:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717100732.435116c8@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox