From: keith.busch@intel.com (Keith Busch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nvme: Acknowledge completion queue on each iteration
Date: Tue, 18 Jul 2017 10:36:17 -0400 [thread overview]
Message-ID: <20170718143617.GA7613@localhost.localdomain> (raw)
In-Reply-To: <79413407294645f0e1252112c3435a29@codeaurora.org>
On Mon, Jul 17, 2017 at 07:07:00PM -0400, okaya at codeaurora.org wrote:
> Maybe, I need to understand the design better. I was curious why completion
> and submission queues were protected by a single lock causing lock
> contention.
Ideally the queues are tied to CPUs, so you couldn't have one thread
submitting to a particular queue-pair while another thread is reaping
completions from it. Such a setup wouldn't get lock contention.
Some machines have so many CPUs, though, that sharing hardware queues
is required. We've experimented with separate submission and completion
locks for such cases, but I've never seen an improved performance as a
result.
next prev parent reply other threads:[~2017-07-18 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 22:36 [PATCH] nvme: Acknowledge completion queue on each iteration Sinan Kaya
2017-07-17 22:45 ` Keith Busch
2017-07-17 22:46 ` Sinan Kaya
2017-07-17 22:56 ` Keith Busch
2017-07-17 23:07 ` okaya at codeaurora.org
2017-07-18 14:36 ` Keith Busch [this message]
2017-07-18 18:52 ` Sinan Kaya
2017-07-18 21:26 ` Keith Busch
2017-07-19 9:20 ` Sagi Grimberg
2017-07-19 10:37 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718143617.GA7613@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).