From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 19 Jul 2017 08:50:19 +0200 Subject: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI In-Reply-To: <20170719063349.m5yg4n2radkvy74r@sapphire.tkos.co.il> References: <1498561654-14658-1-git-send-email-yong.deng@magewell.com> <1498561654-14658-3-git-send-email-yong.deng@magewell.com> <20170718115530.ssy7g5vv4siqnfpo@tarshish> <20170719092249.2fb6ec720ba1b194cea320c8@magewell.com> <20170719044923.yae2ye4slvrmtyfe@sapphire.tkos.co.il> <20170719142120.d00469cf9fce844d40b9988e@magewell.com> <20170719063349.m5yg4n2radkvy74r@sapphire.tkos.co.il> Message-ID: <20170719065019.sc2xivtm4d77vrzw@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 19, 2017 at 09:33:49AM +0300, Baruch Siach wrote: > Hi Yong, > > On Wed, Jul 19, 2017 at 02:21:20PM +0800, Yong wrote: > > On Wed, 19 Jul 2017 07:49:23 +0300 > > Baruch Siach wrote: > > > On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > > > > I am waiting for more comments for the sunxi-csi.h. It's pleasure if > > > > you have any suggestions about it. > > > > > > You mean sunxi_csi.h, right? > > > > Yes. My spelling mistake. > > > > > Why do you need the sunxi_csi_ops indirection? Do you expect to add > > > alternative implementations of these ops at some point? > > > > I want to seperate the sunxi_video.c and sunxi_csi_v3s.c. > > sunxi_csi_v3s.c is Soc specific. Maybe there will be sunxi_csi_r40.c > > in the futrue. But the sunxi_video.c and sunxi_csi.c are common. > > I'd say it is a premature optimization. The file separation is fine, IMO, but > the added csi_ops indirection makes the code less readable. Someone with > access to R40 hardware with CSI setup would be a better position to abstract > the platform specific code. I agree Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: