From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 2/3] mfd: hi6421-pmic: cleanup: update dev_err messages
Date: Thu, 20 Jul 2017 09:53:53 +0100 [thread overview]
Message-ID: <20170720085353.xhy3oldf755fxw46@dell> (raw)
In-Reply-To: <20170720073242.1758-3-guodong.xu@linaro.org>
On Thu, 20 Jul 2017, Guodong Xu wrote:
> Update dev_err messages to make them more readable.
>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/hi6421-pmic-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
> index ad9e3d8..b1139d4 100644
> --- a/drivers/mfd/hi6421-pmic-core.c
> +++ b/drivers/mfd/hi6421-pmic-core.c
> @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev)
> pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base,
> &hi6421_regmap_config);
> if (IS_ERR(pmic->regmap)) {
> - dev_err(&pdev->dev,
> - "regmap init failed: %ld\n", PTR_ERR(pmic->regmap));
> + dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n",
> + PTR_ERR(pmic->regmap));
> return PTR_ERR(pmic->regmap);
> }
>
> @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev)
> ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs,
> ARRAY_SIZE(hi6421_devs), NULL, 0, NULL);
> if (ret) {
> - dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret);
> + dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret);
> return ret;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-07-20 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:32 [PATCH v7 0/3] MFD: add driver for HiSilicon Hi6421v530 PMIC Guodong Xu
2017-07-20 7:32 ` [PATCH v7 1/3] mfd: hi6421-pmic: cleanup: change license text to shorter form Guodong Xu
2017-07-20 8:53 ` Lee Jones
2017-07-20 7:32 ` [PATCH v7 2/3] mfd: hi6421-pmic: cleanup: update dev_err messages Guodong Xu
2017-07-20 8:53 ` Lee Jones [this message]
2017-07-20 7:32 ` [PATCH v7 3/3] mfd: hi6421-pmic: add support for HiSilicon Hi6421v530 Guodong Xu
2017-07-20 8:55 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720085353.xhy3oldf755fxw46@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox